2022-05-02 19:31:27

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: ov5645: Remove unneeded of_match_ptr macro

Hi Moses,

Thank you for the patch.

On Sat, Apr 30, 2022 at 12:27:54AM +0200, Moses Christopher Bollavarapu wrote:
> of_match_ptr isn't required as CONFIG_OF is already a dependency in Kconfig

And the .of_match_table field hasn't been conditional on CONFIG_OF for a
long time now.

> Signed-off-by: Moses Christopher Bollavarapu <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/i2c/ov5645.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
> index 368fa21e675e..ea73c060514d 100644
> --- a/drivers/media/i2c/ov5645.c
> +++ b/drivers/media/i2c/ov5645.c
> @@ -1283,7 +1283,7 @@ MODULE_DEVICE_TABLE(of, ov5645_of_match);
>
> static struct i2c_driver ov5645_i2c_driver = {
> .driver = {
> - .of_match_table = of_match_ptr(ov5645_of_match),
> + .of_match_table = ov5645_of_match,
> .name = "ov5645",
> },
> .probe_new = ov5645_probe,

--
Regards,

Laurent Pinchart