2022-04-21 12:24:57

by Adrien Thierry

Subject: [PATCH] staging: bcm2835-audio: delete TODO

Delete TODO since all tasks were completed:

1 - fixed here:
https://lore.kernel.org/all/[email protected]/

2 - there are no remaining checkpatch.pl errors or warnings

Signed-off-by: Adrien Thierry <[email protected]>
---
drivers/staging/vc04_services/bcm2835-audio/TODO | 10 ----------
1 file changed, 10 deletions(-)
delete mode 100644 drivers/staging/vc04_services/bcm2835-audio/TODO

diff --git a/drivers/staging/vc04_services/bcm2835-audio/TODO b/drivers/staging/vc04_services/bcm2835-audio/TODO
deleted file mode 100644
index b85451255db0..000000000000
--- a/drivers/staging/vc04_services/bcm2835-audio/TODO
+++ /dev/null
@@ -1,10 +0,0 @@
-*****************************************************************************
-* *
-* TODO: BCM2835-AUDIO *
-* *
-*****************************************************************************
-
-1) Revisit multi-cards options and PCM route mixer control (as per comment
-https://lore.kernel.org/lkml/[email protected])
-
-2) Fix the remaining checkpatch.pl errors and warnings.
--
2.35.1

2022-04-22 18:21:03

by Stefan Wahren

Subject: Re: [PATCH] staging: bcm2835-audio: delete TODO

Hi Greg,

Am 22.04.22 um 16:40 schrieb Greg Kroah-Hartman:
> On Wed, Apr 20, 2022 at 01:44:00PM -0400, Adrien Thierry wrote:
>> Delete TODO since all tasks were completed:
>>
>> 1 - fixed here:
>> https://lore.kernel.org/all/[email protected]/
>>
>> 2 - there are no remaining checkpatch.pl errors or warnings
>>
>> Signed-off-by: Adrien Thierry <[email protected]>
>> ---
>> drivers/staging/vc04_services/bcm2835-audio/TODO | 10 ----------
>> 1 file changed, 10 deletions(-)
>> delete mode 100644 drivers/staging/vc04_services/bcm2835-audio/TODO
>>
>> diff --git a/drivers/staging/vc04_services/bcm2835-audio/TODO b/drivers/staging/vc04_services/bcm2835-audio/TODO
>> deleted file mode 100644
>> index b85451255db0..000000000000
>> --- a/drivers/staging/vc04_services/bcm2835-audio/TODO
>> +++ /dev/null
>> @@ -1,10 +0,0 @@
>> -*****************************************************************************
>> -* *
>> -* TODO: BCM2835-AUDIO *
>> -* *
>> -*****************************************************************************
>> -
>> -1) Revisit multi-cards options and PCM route mixer control (as per comment
>> -https://lore.kernel.org/lkml/[email protected])
>> -
>> -2) Fix the remaining checkpatch.pl errors and warnings.
>> --
>> 2.35.1
>>
>>
> Great, so now it can be merged to the real part of the kernel? If not,
> what's left for that to happen?

bcm2835-audio depends on interface/vchiq_arm in a parallel directory.
Its TODO list is a little bit longer.

Best regards

>
> thanks,
>
> greg k-h
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2022-04-22 20:01:23

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: bcm2835-audio: delete TODO

On Wed, Apr 20, 2022 at 01:44:00PM -0400, Adrien Thierry wrote:
> Delete TODO since all tasks were completed:
>
> 1 - fixed here:
> https://lore.kernel.org/all/[email protected]/
>
> 2 - there are no remaining checkpatch.pl errors or warnings
>
> Signed-off-by: Adrien Thierry <[email protected]>
> ---
> drivers/staging/vc04_services/bcm2835-audio/TODO | 10 ----------
> 1 file changed, 10 deletions(-)
> delete mode 100644 drivers/staging/vc04_services/bcm2835-audio/TODO
>
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/TODO b/drivers/staging/vc04_services/bcm2835-audio/TODO
> deleted file mode 100644
> index b85451255db0..000000000000
> --- a/drivers/staging/vc04_services/bcm2835-audio/TODO
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -*****************************************************************************
> -* *
> -* TODO: BCM2835-AUDIO *
> -* *
> -*****************************************************************************
> -
> -1) Revisit multi-cards options and PCM route mixer control (as per comment
> -https://lore.kernel.org/lkml/[email protected])
> -
> -2) Fix the remaining checkpatch.pl errors and warnings.
> --
> 2.35.1
>
>

Great, so now it can be merged to the real part of the kernel? If not,
what's left for that to happen?

thanks,

greg k-h

2022-04-22 21:20:43

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: bcm2835-audio: delete TODO

On Fri, Apr 22, 2022 at 04:58:22PM +0200, Stefan Wahren wrote:
> Hi Greg,
>
> Am 22.04.22 um 16:40 schrieb Greg Kroah-Hartman:
> > On Wed, Apr 20, 2022 at 01:44:00PM -0400, Adrien Thierry wrote:
> > > Delete TODO since all tasks were completed:
> > >
> > > 1 - fixed here:
> > > https://lore.kernel.org/all/[email protected]/
> > >
> > > 2 - there are no remaining checkpatch.pl errors or warnings
> > >
> > > Signed-off-by: Adrien Thierry <[email protected]>
> > > ---
> > > drivers/staging/vc04_services/bcm2835-audio/TODO | 10 ----------
> > > 1 file changed, 10 deletions(-)
> > > delete mode 100644 drivers/staging/vc04_services/bcm2835-audio/TODO
> > >
> > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/TODO b/drivers/staging/vc04_services/bcm2835-audio/TODO
> > > deleted file mode 100644
> > > index b85451255db0..000000000000
> > > --- a/drivers/staging/vc04_services/bcm2835-audio/TODO
> > > +++ /dev/null
> > > @@ -1,10 +0,0 @@
> > > -*****************************************************************************
> > > -* *
> > > -* TODO: BCM2835-AUDIO *
> > > -* *
> > > -*****************************************************************************
> > > -
> > > -1) Revisit multi-cards options and PCM route mixer control (as per comment
> > > -https://lore.kernel.org/lkml/[email protected])
> > > -
> > > -2) Fix the remaining checkpatch.pl errors and warnings.
> > > --
> > > 2.35.1
> > >
> > >
> > Great, so now it can be merged to the real part of the kernel? If not,
> > what's left for that to happen?
>
> bcm2835-audio depends on interface/vchiq_arm in a parallel directory. Its
> TODO list is a little bit longer.

Ah, yeah, still more work to do :(