2022-04-22 17:55:41

by Timothy Hayes

Subject: [PATCH 3/3] perf test: Add perf_event_attr test for Arm SPE

Adds a perf_event_attr test for Arm SPE in which the presence of
physical addresses are checked when SPE unit is run with pa_enable=1.

Signed-off-by: Timothy Hayes <[email protected]>
---
tools/perf/tests/attr/README | 1 +
.../perf/tests/attr/test-record-spe-physical-address | 12 ++++++++++++
2 files changed, 13 insertions(+)
create mode 100644 tools/perf/tests/attr/test-record-spe-physical-address

diff --git a/tools/perf/tests/attr/README b/tools/perf/tests/attr/README
index 454505d343fa..eb3f7d4bb324 100644
--- a/tools/perf/tests/attr/README
+++ b/tools/perf/tests/attr/README
@@ -60,6 +60,7 @@ Following tests are defined (with perf commands):
perf record -R kill (test-record-raw)
perf record -c 2 -e arm_spe_0// -- kill (test-record-spe-period)
perf record -e arm_spe_0/period=3/ -- kill (test-record-spe-period-term)
+ perf record -e arm_spe_0/pa_enable=1/ -- kill (test-record-spe-physical-address)
perf stat -e cycles kill (test-stat-basic)
perf stat kill (test-stat-default)
perf stat -d kill (test-stat-detailed-1)
diff --git a/tools/perf/tests/attr/test-record-spe-physical-address b/tools/perf/tests/attr/test-record-spe-physical-address
new file mode 100644
index 000000000000..7ebcf5012ce3
--- /dev/null
+++ b/tools/perf/tests/attr/test-record-spe-physical-address
@@ -0,0 +1,12 @@
+[config]
+command = record
+args = --no-bpf-event -e arm_spe_0/pa_enable=1/ -- kill >/dev/null 2>&1
+ret = 1
+arch = aarch64
+
+[event-10:base-record-spe]
+# 622727 is the decimal of IP|TID|TIME|CPU|IDENTIFIER|DATA_SRC|PHYS_ADDR
+sample_type=622727
+
+# dummy event
+[event-1:base-record-spe]
\ No newline at end of file
--
2.25.1

2022-04-25 07:12:39

by Leo Yan

Subject: Re: [PATCH 3/3] perf test: Add perf_event_attr test for Arm SPE

On Thu, Apr 21, 2022 at 05:52:05PM +0100, Timothy Hayes wrote:
> Adds a perf_event_attr test for Arm SPE in which the presence of
> physical addresses are checked when SPE unit is run with pa_enable=1.
>
> Signed-off-by: Timothy Hayes <[email protected]>

Reviewed-by: Leo Yan <[email protected]>
Tested-by: Leo Yan <[email protected]>

> ---
> tools/perf/tests/attr/README | 1 +
> .../perf/tests/attr/test-record-spe-physical-address | 12 ++++++++++++
> 2 files changed, 13 insertions(+)
> create mode 100644 tools/perf/tests/attr/test-record-spe-physical-address
>
> diff --git a/tools/perf/tests/attr/README b/tools/perf/tests/attr/README
> index 454505d343fa..eb3f7d4bb324 100644
> --- a/tools/perf/tests/attr/README
> +++ b/tools/perf/tests/attr/README
> @@ -60,6 +60,7 @@ Following tests are defined (with perf commands):
> perf record -R kill (test-record-raw)
> perf record -c 2 -e arm_spe_0// -- kill (test-record-spe-period)
> perf record -e arm_spe_0/period=3/ -- kill (test-record-spe-period-term)
> + perf record -e arm_spe_0/pa_enable=1/ -- kill (test-record-spe-physical-address)
> perf stat -e cycles kill (test-stat-basic)
> perf stat kill (test-stat-default)
> perf stat -d kill (test-stat-detailed-1)
> diff --git a/tools/perf/tests/attr/test-record-spe-physical-address b/tools/perf/tests/attr/test-record-spe-physical-address
> new file mode 100644
> index 000000000000..7ebcf5012ce3
> --- /dev/null
> +++ b/tools/perf/tests/attr/test-record-spe-physical-address
> @@ -0,0 +1,12 @@
> +[config]
> +command = record
> +args = --no-bpf-event -e arm_spe_0/pa_enable=1/ -- kill >/dev/null 2>&1
> +ret = 1
> +arch = aarch64
> +
> +[event-10:base-record-spe]
> +# 622727 is the decimal of IP|TID|TIME|CPU|IDENTIFIER|DATA_SRC|PHYS_ADDR
> +sample_type=622727
> +
> +# dummy event
> +[event-1:base-record-spe]
> \ No newline at end of file
> --
> 2.25.1
>

2022-04-29 12:51:27

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 3/3] perf test: Add perf_event_attr test for Arm SPE

Em Sun, Apr 24, 2022 at 10:53:07PM +0800, Leo Yan escreveu:
> On Thu, Apr 21, 2022 at 05:52:05PM +0100, Timothy Hayes wrote:
> > Adds a perf_event_attr test for Arm SPE in which the presence of
> > physical addresses are checked when SPE unit is run with pa_enable=1.
> >
> > Signed-off-by: Timothy Hayes <[email protected]>
>
> Reviewed-by: Leo Yan <[email protected]>
> Tested-by: Leo Yan <[email protected]>

Thanks, applied the set to perf/urgent.

- Arnaldo

> > ---
> > tools/perf/tests/attr/README | 1 +
> > .../perf/tests/attr/test-record-spe-physical-address | 12 ++++++++++++
> > 2 files changed, 13 insertions(+)
> > create mode 100644 tools/perf/tests/attr/test-record-spe-physical-address
> >
> > diff --git a/tools/perf/tests/attr/README b/tools/perf/tests/attr/README
> > index 454505d343fa..eb3f7d4bb324 100644
> > --- a/tools/perf/tests/attr/README
> > +++ b/tools/perf/tests/attr/README
> > @@ -60,6 +60,7 @@ Following tests are defined (with perf commands):
> > perf record -R kill (test-record-raw)
> > perf record -c 2 -e arm_spe_0// -- kill (test-record-spe-period)
> > perf record -e arm_spe_0/period=3/ -- kill (test-record-spe-period-term)
> > + perf record -e arm_spe_0/pa_enable=1/ -- kill (test-record-spe-physical-address)
> > perf stat -e cycles kill (test-stat-basic)
> > perf stat kill (test-stat-default)
> > perf stat -d kill (test-stat-detailed-1)
> > diff --git a/tools/perf/tests/attr/test-record-spe-physical-address b/tools/perf/tests/attr/test-record-spe-physical-address
> > new file mode 100644
> > index 000000000000..7ebcf5012ce3
> > --- /dev/null
> > +++ b/tools/perf/tests/attr/test-record-spe-physical-address
> > @@ -0,0 +1,12 @@
> > +[config]
> > +command = record
> > +args = --no-bpf-event -e arm_spe_0/pa_enable=1/ -- kill >/dev/null 2>&1
> > +ret = 1
> > +arch = aarch64
> > +
> > +[event-10:base-record-spe]
> > +# 622727 is the decimal of IP|TID|TIME|CPU|IDENTIFIER|DATA_SRC|PHYS_ADDR
> > +sample_type=622727
> > +
> > +# dummy event
> > +[event-1:base-record-spe]
> > \ No newline at end of file
> > --
> > 2.25.1
> >

--

- Arnaldo