Let GPIO library to assign of_node from the parent device.
This allows to move GPIO library and drivers to use fwnode
APIs instead of being stuck with OF-only interfaces.
Signed-off-by: Andy Shevchenko <[email protected]>
---
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
index a38372f9ac12..26b502773b3f 100644
--- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
+++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
@@ -8,15 +8,15 @@
*/
#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/device.h>
#include <linux/mutex.h>
#include <linux/i2c.h>
#include <linux/gpio/driver.h>
-#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/slab.h>
#include <linux/kthread.h>
+#include <linux/property.h>
#include <linux/reboot.h>
#include <asm/prom.h>
#include <asm/machdep.h>
@@ -116,21 +116,17 @@ static int mcu_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
static int mcu_gpiochip_add(struct mcu *mcu)
{
- struct device_node *np;
+ struct device *dev = &mcu->client->dev;
struct gpio_chip *gc = &mcu->gc;
- np = of_find_compatible_node(NULL, NULL, "fsl,mcu-mpc8349emitx");
- if (!np)
- return -ENODEV;
-
gc->owner = THIS_MODULE;
- gc->label = kasprintf(GFP_KERNEL, "%pOF", np);
+ gc->label = kasprintf(GFP_KERNEL, "%pfw", dev_fwnode(dev));
gc->can_sleep = 1;
gc->ngpio = MCU_NUM_GPIO;
gc->base = -1;
gc->set = mcu_gpio_set;
gc->direction_output = mcu_gpio_dir_out;
- gc->of_node = np;
+ gc->parent = dev;
return gpiochip_add_data(gc, mcu);
}
--
2.35.1
On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko
<[email protected]> wrote:
> Let GPIO library to assign of_node from the parent device.
> This allows to move GPIO library and drivers to use fwnode
> APIs instead of being stuck with OF-only interfaces.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
That's a nice patch.
Reviewed-by: Linus Walleij <[email protected]>
Yours,
Linus Walleij
On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote:
> On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko
> <[email protected]> wrote:
>
> > Let GPIO library to assign of_node from the parent device.
> > This allows to move GPIO library and drivers to use fwnode
> > APIs instead of being stuck with OF-only interfaces.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> That's a nice patch.
> Reviewed-by: Linus Walleij <[email protected]>
Thanks!
Can we have this applied now?
--
With Best Regards,
Andy Shevchenko
On Wed, 2022-03-23 at 19:43 +0200, Andy Shevchenko wrote:
> Let GPIO library to assign of_node from the parent device.
> This allows to move GPIO library and drivers to use fwnode
> APIs instead of being stuck with OF-only interfaces.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
Acked-by: Scott Wood <[email protected]>
-Scott
On Wed, Apr 6, 2022 at 3:02 PM Andy Shevchenko
<[email protected]> wrote:
> On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote:
> > On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko
> > <[email protected]> wrote:
> >
> > > Let GPIO library to assign of_node from the parent device.
> > > This allows to move GPIO library and drivers to use fwnode
> > > APIs instead of being stuck with OF-only interfaces.
> > >
> > > Signed-off-by: Andy Shevchenko <[email protected]>
> >
> > That's a nice patch.
> > Reviewed-by: Linus Walleij <[email protected]>
>
> Thanks!
>
> Can we have this applied now?
I think Michael Ellerman could help with this?
Michael?
Yours,
Linus Walleij
Linus Walleij <[email protected]> writes:
> On Wed, Apr 6, 2022 at 3:02 PM Andy Shevchenko
> <[email protected]> wrote:
>> On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote:
>> > On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko
>> > <[email protected]> wrote:
>> >
>> > > Let GPIO library to assign of_node from the parent device.
>> > > This allows to move GPIO library and drivers to use fwnode
>> > > APIs instead of being stuck with OF-only interfaces.
>> > >
>> > > Signed-off-by: Andy Shevchenko <[email protected]>
>> >
>> > That's a nice patch.
>> > Reviewed-by: Linus Walleij <[email protected]>
>>
>> Thanks!
>>
>> Can we have this applied now?
>
> I think Michael Ellerman could help with this?
>
> Michael?
Yep, I'll pick it up when I start putting things into next.
That's usually the week after rc2, but I had a break for Easter.
cheers
On Thu, Apr 21, 2022 at 08:42:30AM +1000, Michael Ellerman wrote:
> Linus Walleij <[email protected]> writes:
> > On Wed, Apr 6, 2022 at 3:02 PM Andy Shevchenko
> > <[email protected]> wrote:
> >> On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote:
> >> > On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko
> >> > <[email protected]> wrote:
> >> >
> >> > > Let GPIO library to assign of_node from the parent device.
> >> > > This allows to move GPIO library and drivers to use fwnode
> >> > > APIs instead of being stuck with OF-only interfaces.
> >> > >
> >> > > Signed-off-by: Andy Shevchenko <[email protected]>
> >> >
> >> > That's a nice patch.
> >> > Reviewed-by: Linus Walleij <[email protected]>
> >>
> >> Thanks!
> >>
> >> Can we have this applied now?
> >
> > I think Michael Ellerman could help with this?
> >
> > Michael?
>
> Yep, I'll pick it up when I start putting things into next.
>
> That's usually the week after rc2, but I had a break for Easter.
Any new on this? I haven't seen it yet in Linux Next.
--
With Best Regards,
Andy Shevchenko
Andy Shevchenko <[email protected]> writes:
> On Thu, Apr 21, 2022 at 08:42:30AM +1000, Michael Ellerman wrote:
>> Linus Walleij <[email protected]> writes:
>> > On Wed, Apr 6, 2022 at 3:02 PM Andy Shevchenko
>> > <[email protected]> wrote:
>> >> On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote:
>> >> > On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko
>> >> > <[email protected]> wrote:
>> >> >
>> >> > > Let GPIO library to assign of_node from the parent device.
>> >> > > This allows to move GPIO library and drivers to use fwnode
>> >> > > APIs instead of being stuck with OF-only interfaces.
>> >> > >
>> >> > > Signed-off-by: Andy Shevchenko <[email protected]>
>> >> >
>> >> > That's a nice patch.
>> >> > Reviewed-by: Linus Walleij <[email protected]>
>> >>
>> >> Thanks!
>> >>
>> >> Can we have this applied now?
>> >
>> > I think Michael Ellerman could help with this?
>> >
>> > Michael?
>>
>> Yep, I'll pick it up when I start putting things into next.
>>
>> That's usually the week after rc2, but I had a break for Easter.
>
> Any new on this? I haven't seen it yet in Linux Next.
It's in today's next (next-20220505).
cheers
On Thu, May 05, 2022 at 09:04:46PM +1000, Michael Ellerman wrote:
> Andy Shevchenko <[email protected]> writes:
> > On Thu, Apr 21, 2022 at 08:42:30AM +1000, Michael Ellerman wrote:
...
> > Any new on this? I haven't seen it yet in Linux Next.
>
> It's in today's next (next-20220505).
Got it, thank you!
--
With Best Regards,
Andy Shevchenko
On Wed, 23 Mar 2022 19:43:42 +0200, Andy Shevchenko wrote:
> Let GPIO library to assign of_node from the parent device.
> This allows to move GPIO library and drivers to use fwnode
> APIs instead of being stuck with OF-only interfaces.
>
>
Applied to powerpc/next.
[1/1] powerpc/83xx/mpc8349emitx: Get rid of of_node assignment
https://git.kernel.org/powerpc/c/610cc9f45881f1a3758f323d6d7d67e572958c3b
cheers