On Mon, Jun 06, 2022 at 09:37:55PM -0400, Tianfei Zhang wrote:
> From: Matthew Gerlach <[email protected]>
>
> This patch adds support for regmap APIs that are intended to be used by
> the drivers of some devices which support generic indirect register access,
> for example PMCI (Platform Management Control Interface) device, HSSI
> (High Speed Serial Interface) device in FPGA.
>
> Signed-off-by: Matthew Gerlach <[email protected]>
> Signed-off-by: Tianfei Zhang <[email protected]>
> ---
> drivers/base/regmap/Kconfig | 3 +
> drivers/base/regmap/Makefile | 1 +
> .../base/regmap/regmap-indirect-register.c | 133 ++++++++++++++++++
> include/linux/regmap.h | 12 ++
> 4 files changed, 149 insertions(+)
> create mode 100644 drivers/base/regmap/regmap-indirect-register.c
Don't we need users of these before we can take them?
thanks,
greg k-h
> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Tuesday, June 7, 2022 12:50 PM
> To: Zhang, Tianfei <[email protected]>
> Cc: [email protected]; [email protected]; [email protected]; Wu,
> Hao <[email protected]>; [email protected]; Xu, Yilun <[email protected]>;
> Weight, Russell H <[email protected]>; Matthew Gerlach
> <[email protected]>
> Subject: Re: [PATCH v1] regmap: add generic indirect regmap support
>
> On Mon, Jun 06, 2022 at 09:37:55PM -0400, Tianfei Zhang wrote:
> > From: Matthew Gerlach <[email protected]>
> >
> > This patch adds support for regmap APIs that are intended to be used
> > by the drivers of some devices which support generic indirect register
> > access, for example PMCI (Platform Management Control Interface)
> > device, HSSI (High Speed Serial Interface) device in FPGA.
> >
> > Signed-off-by: Matthew Gerlach <[email protected]>
> > Signed-off-by: Tianfei Zhang <[email protected]>
> > ---
> > drivers/base/regmap/Kconfig | 3 +
> > drivers/base/regmap/Makefile | 1 +
> > .../base/regmap/regmap-indirect-register.c | 133 ++++++++++++++++++
> > include/linux/regmap.h | 12 ++
> > 4 files changed, 149 insertions(+)
> > create mode 100644 drivers/base/regmap/regmap-indirect-register.c
>
> Don't we need users of these before we can take them?
One of user is the PMCI (Platform Management Control Interface) driver of Intel FPGA PAC Card,
PMCI device was connected to card BMC which provided telemetry and mailbox functionalities.
The PMCI driver is under review now:
https://lore.kernel.org/all/[email protected]/