2022-05-27 14:48:29

by Jiapeng Chong

Subject: [PATCH v2] dmaengine: altera-msgdma: Fix kernel-doc

Fix the following W=1 kernel warnings:

drivers/dma/altera-msgdma.c:927: warning: expecting prototype for
msgdma_dma_remove(). Prototype was for msgdma_remove() instead.

drivers/dma/altera-msgdma.c:758: warning: expecting prototype for
msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
Changes in v2:
-Make the commit message more clearer,replace msgdma_remove()
with msgdma_dma_remove() in doc.

drivers/dma/altera-msgdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
index 6f56dfd375e3..4153c2edb049 100644
--- a/drivers/dma/altera-msgdma.c
+++ b/drivers/dma/altera-msgdma.c
@@ -749,7 +749,7 @@ static irqreturn_t msgdma_irq_handler(int irq, void *data)
}

/**
- * msgdma_chan_remove - Channel remove function
+ * msgdma_dev_remove() - Device remove function
* @mdev: Pointer to the Altera mSGDMA device structure
*/
static void msgdma_dev_remove(struct msgdma_device *mdev)
@@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev)
}

/**
- * msgdma_dma_remove - Driver remove function
+ * msgdma_remove() - Driver remove function
* @pdev: Pointer to the platform_device structure
*
* Return: Always '0'
--
2.20.1.7.g153144c

2022-05-31 23:15:08

by Olivier Dautricourt

Subject: Re: [PATCH v2] dmaengine: altera-msgdma: Fix kernel-doc

On Fri, May 27, 2022 at 03:40:08PM +0800, Jiapeng Chong wrote:
> Fix the following W=1 kernel warnings:
>
> drivers/dma/altera-msgdma.c:927: warning: expecting prototype for
> msgdma_dma_remove(). Prototype was for msgdma_remove() instead.
>
> drivers/dma/altera-msgdma.c:758: warning: expecting prototype for
> msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> Changes in v2:
> -Make the commit message more clearer,replace msgdma_remove()
> with msgdma_dma_remove() in doc.

Acked-by: Olivier Dautricourt <[email protected]>

Thanks !
>
> drivers/dma/altera-msgdma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index 6f56dfd375e3..4153c2edb049 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -749,7 +749,7 @@ static irqreturn_t msgdma_irq_handler(int irq, void *data)
> }
>
> /**
> - * msgdma_chan_remove - Channel remove function
> + * msgdma_dev_remove() - Device remove function
> * @mdev: Pointer to the Altera mSGDMA device structure
> */
> static void msgdma_dev_remove(struct msgdma_device *mdev)
> @@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev)
> }
>
> /**
> - * msgdma_dma_remove - Driver remove function
> + * msgdma_remove() - Driver remove function
> * @pdev: Pointer to the platform_device structure
> *
> * Return: Always '0'
> --
> 2.20.1.7.g153144c
>