2022-06-08 08:52:20

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the spi tree

Hi all,

After merging the spi tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/spi/spi.h:82: warning: Function parameter or member 'syncp' not described in 'spi_statistics'
include/linux/spi/spi.h:213: warning: Function parameter or member 'pcpu_statistics' not described in 'spi_device'
include/linux/spi/spi.h:676: warning: Function parameter or member 'pcpu_statistics' not described in 'spi_controller'

Introduced by commit

6598b91b5ac3 ("spi: spi.c: Convert statistics to per-cpu u64_stats_t")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-06-08 08:55:18

by David Jander

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the spi tree


Hi Mark, Stephen,

On Wed, 8 Jun 2022 14:30:38 +1000
Stephen Rothwell <[email protected]> wrote:

> Hi all,
>
> After merging the spi tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/linux/spi/spi.h:82: warning: Function parameter or member 'syncp' not described in 'spi_statistics'
> include/linux/spi/spi.h:213: warning: Function parameter or member 'pcpu_statistics' not described in 'spi_device'
> include/linux/spi/spi.h:676: warning: Function parameter or member 'pcpu_statistics' not described in 'spi_controller'
>
> Introduced by commit
>
> 6598b91b5ac3 ("spi: spi.c: Convert statistics to per-cpu u64_stats_t")
>

This is my fault. @Mark: Should/must I do something about this now that it
already hit the next tree? How to proceed?

Best regards,

--
David Jander

2022-06-08 10:55:15

by Mark Brown

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the spi tree

On Wed, Jun 08, 2022 at 09:30:52AM +0200, David Jander wrote:
> Stephen Rothwell <[email protected]> wrote:

> >
> > include/linux/spi/spi.h:82: warning: Function parameter or member 'syncp' not described in 'spi_statistics'
> > include/linux/spi/spi.h:213: warning: Function parameter or member 'pcpu_statistics' not described in 'spi_device'
> > include/linux/spi/spi.h:676: warning: Function parameter or member 'pcpu_statistics' not described in 'spi_controller'

> > Introduced by commit

> > 6598b91b5ac3 ("spi: spi.c: Convert statistics to per-cpu u64_stats_t")

> This is my fault. @Mark: Should/must I do something about this now that it
> already hit the next tree? How to proceed?

It'd be great if you could send an incremental fix adding the
appropriate documentation.


Attachments:
(No filename) (805.00 B)
signature.asc (499.00 B)
Download all attachments