2022-06-10 03:07:49

by Deming Wang

[permalink] [raw]

Subject: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs

---

fs parameter not used. So, it needs to be deleted.

Signed-off-by: Deming Wang <[email protected]>
---
fs/fuse/virtio_fs.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 8db53fa67359..0991199d19c1 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -741,8 +741,7 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,
}

/* Free virtqueues (device must already be reset) */
-static void virtio_fs_cleanup_vqs(struct virtio_device *vdev,
- struct virtio_fs *fs)
+static void virtio_fs_cleanup_vqs(struct virtio_device *vdev)
{
vdev->config->del_vqs(vdev);
}
@@ -895,7 +894,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)

out_vqs:
virtio_reset_device(vdev);
- virtio_fs_cleanup_vqs(vdev, fs);
+ virtio_fs_cleanup_vqs(vdev);
kfree(fs->vqs);

out:
@@ -927,7 +926,7 @@ static void virtio_fs_remove(struct virtio_device *vdev)
virtio_fs_stop_all_queues(fs);
virtio_fs_drain_all_queues_locked(fs);
virtio_reset_device(vdev);
- virtio_fs_cleanup_vqs(vdev, fs);
+ virtio_fs_cleanup_vqs(vdev);

vdev->priv = NULL;
/* Put device reference on virtio_fs object */
--
2.27.0

2022-06-15 16:09:22

by Stefan Hajnoczi

[permalink] [raw]

Subject: Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs

---

On Thu, Jun 09, 2022 at 10:08:38PM -0400, Deming Wang wrote:
> fs parameter not used. So, it needs to be deleted.
>
> Signed-off-by: Deming Wang <[email protected]>
> ---
> fs/fuse/virtio_fs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>

---

Attachments:

(No filename) (323.00 B)
signature.asc (499.00 B)
Download all attachments

2022-06-15 18:16:16

by Vivek Goyal

[permalink] [raw]

Subject: Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs

---

On Thu, Jun 09, 2022 at 10:08:38PM -0400, Deming Wang wrote:
> fs parameter not used. So, it needs to be deleted.
>
> Signed-off-by: Deming Wang <[email protected]>

Thanks Deming Wang for the patch. Good cleanup.

Reviewed-by: Vivek Goyal <[email protected]>

Thanks
Vivek

> ---
> fs/fuse/virtio_fs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 8db53fa67359..0991199d19c1 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -741,8 +741,7 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,
> }
>
> /* Free virtqueues (device must already be reset) */
> -static void virtio_fs_cleanup_vqs(struct virtio_device *vdev,
> - struct virtio_fs *fs)
> +static void virtio_fs_cleanup_vqs(struct virtio_device *vdev)
> {
> vdev->config->del_vqs(vdev);
> }
> @@ -895,7 +894,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
>
> out_vqs:
> virtio_reset_device(vdev);
> - virtio_fs_cleanup_vqs(vdev, fs);
> + virtio_fs_cleanup_vqs(vdev);
> kfree(fs->vqs);
>
> out:
> @@ -927,7 +926,7 @@ static void virtio_fs_remove(struct virtio_device *vdev)
> virtio_fs_stop_all_queues(fs);
> virtio_fs_drain_all_queues_locked(fs);
> virtio_reset_device(vdev);
> - virtio_fs_cleanup_vqs(vdev, fs);
> + virtio_fs_cleanup_vqs(vdev);
>
> vdev->priv = NULL;
> /* Put device reference on virtio_fs object */
> --
> 2.27.0
>

2022-07-18 14:16:10

by Miklos Szeredi

[permalink] [raw]

Subject: Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs

---

On Fri, 10 Jun 2022 at 04:08, Deming Wang <[email protected]> wrote:
>
> fs parameter not used. So, it needs to be deleted.
>
> Signed-off-by: Deming Wang <[email protected]>

Thanks, applied.

Miklos