2022-06-10 11:20:26

by Lino Sanfilippo

Subject: [PATCH v5 09/10] tpm, tpm_tis: Claim locality in interrupt handler

From: Lino Sanfilippo <[email protected]>

Writing the TPM_INT_STATUS register in the interrupt handler to clear the
interrupts only has effect if a locality is held. Since this is not
guaranteed at the time the interrupt is fired, claim the locality
explicitly in the handler.

Signed-off-by: Lino Sanfilippo <[email protected]>
---
drivers/char/tpm/tpm_tis_core.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 8b5aa4fdbe92..e5edf745fb23 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -753,7 +753,9 @@ static irqreturn_t tis_int_handler(int dummy, void *dev_id)
wake_up_interruptible(&priv->int_queue);

/* Clear interrupts handled with TPM_EOI */
+ request_locality(chip, 0);
rc = tpm_tis_write32(priv, TPM_INT_STATUS(priv->locality), interrupt);
+ release_locality(chip, 0);
if (rc < 0)
return IRQ_NONE;

--
2.36.1

2022-06-15 18:42:21

by Jarkko Sakkinen

Subject: Re: [PATCH v5 09/10] tpm, tpm_tis: Claim locality in interrupt handler

On Fri, Jun 10, 2022 at 01:08:45PM +0200, [email protected] wrote:
> From: Lino Sanfilippo <[email protected]>
>
> Writing the TPM_INT_STATUS register in the interrupt handler to clear the
> interrupts only has effect if a locality is held. Since this is not
> guaranteed at the time the interrupt is fired, claim the locality
> explicitly in the handler.
>
> Signed-off-by: Lino Sanfilippo <[email protected]>
> ---
> drivers/char/tpm/tpm_tis_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 8b5aa4fdbe92..e5edf745fb23 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -753,7 +753,9 @@ static irqreturn_t tis_int_handler(int dummy, void *dev_id)
> wake_up_interruptible(&priv->int_queue);
>
> /* Clear interrupts handled with TPM_EOI */
> + request_locality(chip, 0);
> rc = tpm_tis_write32(priv, TPM_INT_STATUS(priv->locality), interrupt);
> + release_locality(chip, 0);
> if (rc < 0)
> return IRQ_NONE;
>
> --
> 2.36.1
>

Reviewed-by: Jarkko Sakkinen <[email protected]>

BR, Jarkko