2022-06-28 10:00:58

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH 18/22] regulator: fix a kernel-doc warning

document n_ramp_values field at struct regulator_desc, in order
to solve this warning:

include/linux/regulator/driver.h:434: warning: Function parameter or member 'n_ramp_values' not described in 'regulator_desc'

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 00/22] at: https://lore.kernel.org/all/[email protected]/

include/linux/regulator/driver.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h
index 0228caaa6741..f9a7461e72b8 100644
--- a/include/linux/regulator/driver.h
+++ b/include/linux/regulator/driver.h
@@ -348,6 +348,7 @@ enum regulator_type {
* @ramp_delay_table: Table for mapping the regulator ramp-rate values. Values
* should be given in units of V/S (uV/uS). See the
* regulator_set_ramp_delay_regmap().
+ * @n_ramp_values: number of elements at @ramp_delay_table.
*
* @enable_time: Time taken for initial enable of regulator (in uS).
* @off_on_delay: guard time (in uS), before re-enabling a regulator
--
2.36.1


2022-06-28 10:46:02

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 18/22] regulator: fix a kernel-doc warning

On Tue, Jun 28, 2022 at 10:46:22AM +0100, Mauro Carvalho Chehab wrote:
> document n_ramp_values field at struct regulator_desc, in order
> to solve this warning:

This is patch 18 of a series for which I don't have a cover letter or
anything. What's the story with dependencies here?


Attachments:
(No filename) (291.00 B)
signature.asc (499.00 B)
Download all attachments

2022-06-28 11:22:39

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH 18/22] regulator: fix a kernel-doc warning

Em Tue, 28 Jun 2022 11:35:00 +0100
Mark Brown <[email protected]> escreveu:

> On Tue, Jun 28, 2022 at 10:46:22AM +0100, Mauro Carvalho Chehab wrote:
> > document n_ramp_values field at struct regulator_desc, in order
> > to solve this warning:
>
> This is patch 18 of a series for which I don't have a cover letter or
> anything. What's the story with dependencies here?

There are no dependnecies. Each patch in this series is independent,
touching different files.

Regards,
Mauro

2022-06-28 11:24:31

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 18/22] regulator: fix a kernel-doc warning

On Tue, Jun 28, 2022 at 12:07:15PM +0100, Mauro Carvalho Chehab wrote:
> Mark Brown <[email protected]> escreveu:
> > On Tue, Jun 28, 2022 at 10:46:22AM +0100, Mauro Carvalho Chehab wrote:

> > > document n_ramp_values field at struct regulator_desc, in order
> > > to solve this warning:

> > This is patch 18 of a series for which I don't have a cover letter or
> > anything. What's the story with dependencies here?

> There are no dependnecies. Each patch in this series is independent,
> touching different files.

OK. In cases like this it really does generally help to send the
patches indepdently (or perhaps split per subsystem), it avoids
confusion.


Attachments:
(No filename) (681.00 B)
signature.asc (499.00 B)
Download all attachments