2022-06-27 07:40:53

by Sebastian Fricke

Subject: [PATCH] media: Fix incorrect P010 chroma order description

The chroma order of P010 is `CbCr`,
match with the descriptions in `include/uapi/linux/videodev2.h` and the
documentation.

Fixes: 5374d8fb75f31 Add P010 video format

Signed-off-by: Sebastian Fricke <[email protected]>
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index e2526701294e..e03362c8aef9 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1306,7 +1306,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
case V4L2_PIX_FMT_NV61: descr = "Y/CrCb 4:2:2"; break;
case V4L2_PIX_FMT_NV24: descr = "Y/CbCr 4:4:4"; break;
case V4L2_PIX_FMT_NV42: descr = "Y/CrCb 4:4:4"; break;
- case V4L2_PIX_FMT_P010: descr = "10-bit Y/CrCb 4:2:0"; break;
+ case V4L2_PIX_FMT_P010: descr = "10-bit Y/CbCr 4:2:0"; break;
case V4L2_PIX_FMT_NV12_4L4: descr = "Y/CbCr 4:2:0 (4x4 Linear)"; break;
case V4L2_PIX_FMT_NV12_16L16: descr = "Y/CbCr 4:2:0 (16x16 Linear)"; break;
case V4L2_PIX_FMT_NV12_32L32: descr = "Y/CbCr 4:2:0 (32x32 Linear)"; break;
--
2.25.1

2022-06-27 09:25:12

by Laurent Pinchart

Subject: Re: [PATCH] media: Fix incorrect P010 chroma order description

Hi Sebastian,

Thank you for the patch.

On Mon, Jun 27, 2022 at 09:12:23AM +0200, Sebastian Fricke wrote:
> The chroma order of P010 is `CbCr`,
> match with the descriptions in `include/uapi/linux/videodev2.h` and the
> documentation.
>
> Fixes: 5374d8fb75f31 Add P010 video format

This should be

Fixes: 5374d8fb75f3 ("media: Add P010 video format")

I recommend adding the following to your ~/.gitconfig:

[pretty]
fixes = Fixes: %h (\"%s\")

You can then use `git show --pretty=fixes -s` to generate the right
Fixes: tag. If you fix lots of bugs, an alias in your ~/.bashrc is also
useful:

gpf() {
git show --pretty=fixes -s ${1:-HEAD} | xclip -selection clipboard
}

> Signed-off-by: Sebastian Fricke <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index e2526701294e..e03362c8aef9 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1306,7 +1306,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> case V4L2_PIX_FMT_NV61: descr = "Y/CrCb 4:2:2"; break;
> case V4L2_PIX_FMT_NV24: descr = "Y/CbCr 4:4:4"; break;
> case V4L2_PIX_FMT_NV42: descr = "Y/CrCb 4:4:4"; break;
> - case V4L2_PIX_FMT_P010: descr = "10-bit Y/CrCb 4:2:0"; break;
> + case V4L2_PIX_FMT_P010: descr = "10-bit Y/CbCr 4:2:0"; break;
> case V4L2_PIX_FMT_NV12_4L4: descr = "Y/CbCr 4:2:0 (4x4 Linear)"; break;
> case V4L2_PIX_FMT_NV12_16L16: descr = "Y/CbCr 4:2:0 (16x16 Linear)"; break;
> case V4L2_PIX_FMT_NV12_32L32: descr = "Y/CbCr 4:2:0 (32x32 Linear)"; break;

--
Regards,

Laurent Pinchart

2022-06-27 17:32:30

by Sebastian Fricke

Subject: Re: [PATCH] media: Fix incorrect P010 chroma order description

Hey Laurent,

On 27.06.2022 11:42, Laurent Pinchart wrote:
>Hi Sebastian,
>
>Thank you for the patch.
>
>On Mon, Jun 27, 2022 at 09:12:23AM +0200, Sebastian Fricke wrote:
>> The chroma order of P010 is `CbCr`,
>> match with the descriptions in `include/uapi/linux/videodev2.h` and the
>> documentation.
>>
>> Fixes: 5374d8fb75f31 Add P010 video format
>
>This should be
>
>Fixes: 5374d8fb75f3 ("media: Add P010 video format")

I assume this can probably be fixed while merging it right? So, I don't
have to resend it.

>
>I recommend adding the following to your ~/.gitconfig:
>
>[pretty]
> fixes = Fixes: %h (\"%s\")
>
>You can then use `git show --pretty=fixes -s` to generate the right
>Fixes: tag. If you fix lots of bugs, an alias in your ~/.bashrc is also
>useful:
>
>gpf() {
> git show --pretty=fixes -s ${1:-HEAD} | xclip -selection clipboard
>}

Thanks a lot for the advice :).

>
>> Signed-off-by: Sebastian Fricke <[email protected]>
>
>Reviewed-by: Laurent Pinchart <[email protected]>

Greetings,
Sebastian

>
>> ---
>> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
>> index e2526701294e..e03362c8aef9 100644
>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
>> @@ -1306,7 +1306,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>> case V4L2_PIX_FMT_NV61: descr = "Y/CrCb 4:2:2"; break;
>> case V4L2_PIX_FMT_NV24: descr = "Y/CbCr 4:4:4"; break;
>> case V4L2_PIX_FMT_NV42: descr = "Y/CrCb 4:4:4"; break;
>> - case V4L2_PIX_FMT_P010: descr = "10-bit Y/CrCb 4:2:0"; break;
>> + case V4L2_PIX_FMT_P010: descr = "10-bit Y/CbCr 4:2:0"; break;
>> case V4L2_PIX_FMT_NV12_4L4: descr = "Y/CbCr 4:2:0 (4x4 Linear)"; break;
>> case V4L2_PIX_FMT_NV12_16L16: descr = "Y/CbCr 4:2:0 (16x16 Linear)"; break;
>> case V4L2_PIX_FMT_NV12_32L32: descr = "Y/CbCr 4:2:0 (32x32 Linear)"; break;
>
>--
>Regards,
>
>Laurent Pinchart

2022-06-27 19:39:59

by Laurent Pinchart

Subject: Re: [PATCH] media: Fix incorrect P010 chroma order description

Hi Sebastian,

On Mon, Jun 27, 2022 at 07:02:09PM +0200, Sebastian Fricke wrote:
> On 27.06.2022 11:42, Laurent Pinchart wrote:
> > On Mon, Jun 27, 2022 at 09:12:23AM +0200, Sebastian Fricke wrote:
> >> The chroma order of P010 is `CbCr`,
> >> match with the descriptions in `include/uapi/linux/videodev2.h` and the
> >> documentation.
> >>
> >> Fixes: 5374d8fb75f31 Add P010 video format
> >
> > This should be
> >
> > Fixes: 5374d8fb75f3 ("media: Add P010 video format")
>
> I assume this can probably be fixed while merging it right? So, I don't
> have to resend it.

No need to resend indeed, this can be fixed when merging.

> > I recommend adding the following to your ~/.gitconfig:
> >
> > [pretty]
> > fixes = Fixes: %h (\"%s\")
> >
> > You can then use `git show --pretty=fixes -s` to generate the right
> > Fixes: tag. If you fix lots of bugs, an alias in your ~/.bashrc is also
> > useful:
> >
> > gpf() {
> > git show --pretty=fixes -s ${1:-HEAD} | xclip -selection clipboard
> > }
>
> Thanks a lot for the advice :).
>
> >
> >> Signed-off-by: Sebastian Fricke <[email protected]>
> >
> > Reviewed-by: Laurent Pinchart <[email protected]>
> >
> >> ---
> >> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> >> index e2526701294e..e03362c8aef9 100644
> >> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> >> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> >> @@ -1306,7 +1306,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> >> case V4L2_PIX_FMT_NV61: descr = "Y/CrCb 4:2:2"; break;
> >> case V4L2_PIX_FMT_NV24: descr = "Y/CbCr 4:4:4"; break;
> >> case V4L2_PIX_FMT_NV42: descr = "Y/CrCb 4:4:4"; break;
> >> - case V4L2_PIX_FMT_P010: descr = "10-bit Y/CrCb 4:2:0"; break;
> >> + case V4L2_PIX_FMT_P010: descr = "10-bit Y/CbCr 4:2:0"; break;
> >> case V4L2_PIX_FMT_NV12_4L4: descr = "Y/CbCr 4:2:0 (4x4 Linear)"; break;
> >> case V4L2_PIX_FMT_NV12_16L16: descr = "Y/CbCr 4:2:0 (16x16 Linear)"; break;
> >> case V4L2_PIX_FMT_NV12_32L32: descr = "Y/CbCr 4:2:0 (32x32 Linear)"; break;

--
Regards,

Laurent Pinchart

2022-06-28 19:08:24

by Ezequiel Garcia

Subject: Re: [PATCH] media: Fix incorrect P010 chroma order description

On Mon, Jun 27, 2022 at 09:12:23AM +0200, Sebastian Fricke wrote:
> The chroma order of P010 is `CbCr`,
> match with the descriptions in `include/uapi/linux/videodev2.h` and the
> documentation.
>
> Fixes: 5374d8fb75f31 Add P010 video format
>
> Signed-off-by: Sebastian Fricke <[email protected]>

Reviewed-by: Ezequiel Garcia <[email protected]>

> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index e2526701294e..e03362c8aef9 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1306,7 +1306,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> case V4L2_PIX_FMT_NV61: descr = "Y/CrCb 4:2:2"; break;
> case V4L2_PIX_FMT_NV24: descr = "Y/CbCr 4:4:4"; break;
> case V4L2_PIX_FMT_NV42: descr = "Y/CrCb 4:4:4"; break;
> - case V4L2_PIX_FMT_P010: descr = "10-bit Y/CrCb 4:2:0"; break;
> + case V4L2_PIX_FMT_P010: descr = "10-bit Y/CbCr 4:2:0"; break;
> case V4L2_PIX_FMT_NV12_4L4: descr = "Y/CbCr 4:2:0 (4x4 Linear)"; break;
> case V4L2_PIX_FMT_NV12_16L16: descr = "Y/CbCr 4:2:0 (16x16 Linear)"; break;
> case V4L2_PIX_FMT_NV12_32L32: descr = "Y/CbCr 4:2:0 (32x32 Linear)"; break;
> --
> 2.25.1
>