2022-07-07 09:43:40

by Chao Liu

Subject: [PATCH v2] f2fs: allow compression of files without blocks

From: Chao Liu <[email protected]>

Files created by truncate(1) have a size but no blocks, so
they can be allowed to enable compression.

Signed-off-by: Chao Liu <[email protected]>
---
v2:
- update commit message: truncate -> truncate(1)

fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 0f29af7876a6..f7a82858486a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
if (iflags & F2FS_COMPR_FL) {
if (!f2fs_may_compress(inode))
return -EINVAL;
- if (S_ISREG(inode->i_mode) && inode->i_size)
+ if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
return -EINVAL;

set_compress_context(inode);
--
2.36.1

2022-07-07 13:49:09

by Chao Yu

Subject: Re: [PATCH v2] f2fs: allow compression of files without blocks

On 2022/7/7 17:09, Chao Liu wrote:
> From: Chao Liu <[email protected]>
>
> Files created by truncate(1) have a size but no blocks, so
> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2022-07-12 01:57:14

by Jaegeuk Kim

Subject: Re: [PATCH v2] f2fs: allow compression of files without blocks

On 07/07, Chao Liu wrote:
> From: Chao Liu <[email protected]>
>
> Files created by truncate(1) have a size but no blocks, so
> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <[email protected]>
> ---
> v2:
> - update commit message: truncate -> truncate(1)
>
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 0f29af7876a6..f7a82858486a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> if (iflags & F2FS_COMPR_FL) {
> if (!f2fs_may_compress(inode))
> return -EINVAL;
> - if (S_ISREG(inode->i_mode) && inode->i_size)
> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))

What about inline_data case?

> return -EINVAL;
>
> set_compress_context(inode);
> --
> 2.36.1

2022-07-12 03:33:25

by Chao Yu

Subject: Re: [PATCH v2] f2fs: allow compression of files without blocks

On 2022/7/12 9:36, Jaegeuk Kim wrote:
> On 07/07, Chao Liu wrote:
>> From: Chao Liu <[email protected]>
>>
>> Files created by truncate(1) have a size but no blocks, so
>> they can be allowed to enable compression.
>>
>> Signed-off-by: Chao Liu <[email protected]>
>> ---
>> v2:
>> - update commit message: truncate -> truncate(1)
>>
>> fs/f2fs/file.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> index 0f29af7876a6..f7a82858486a 100644
>> --- a/fs/f2fs/file.c
>> +++ b/fs/f2fs/file.c
>> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>> if (iflags & F2FS_COMPR_FL) {
>> if (!f2fs_may_compress(inode))
>> return -EINVAL;
>> - if (S_ISREG(inode->i_mode) && inode->i_size)
>> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
>
> What about inline_data case?

How about fixing this w/ a separated patch?

f2fs: fix to check inline_data during compressed inode conversion

Thanks,

>
>> return -EINVAL;
>>
>> set_compress_context(inode);
>> --
>> 2.36.1