2022-07-13 21:14:54

by John Stultz

[permalink] [raw]
Subject: Re: [PATCH 0/9] selftests: timers: fixes and improvements

On Wed, Jul 13, 2022 at 1:46 PM Wolfram Sang
<[email protected]> wrote:
>
> The timer selftests are quite useful for me when enabling timers on new
> SoCs, e.g. like now with the CMT timer on a Renesas R-Car S4-8. During
> development, I needed these fixes and additions to make full use of
> the tests. I think they make all sense upstream, so here they are.
>
> Patches are based on v5.19-rc1. Looking forward to comments.
>

Hey!
Thanks so much I really appreciate the effort to make and send out
these cleanups. From the initial skim it all looks great (though, some
are slightly embarrassing :), and I think some of the extra config
args will be quite nice for others to use as well.

Acked-by: John Stultz <[email protected]>

Thanks so much for submitting these.
-john


2022-07-14 00:21:19

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 0/9] selftests: timers: fixes and improvements

On 7/13/22 3:02 PM, John Stultz wrote:
> On Wed, Jul 13, 2022 at 1:46 PM Wolfram Sang
> <[email protected]> wrote:
>>
>> The timer selftests are quite useful for me when enabling timers on new
>> SoCs, e.g. like now with the CMT timer on a Renesas R-Car S4-8. During
>> development, I needed these fixes and additions to make full use of
>> the tests. I think they make all sense upstream, so here they are.
>>
>> Patches are based on v5.19-rc1. Looking forward to comments.
>>
>
> Hey!
> Thanks so much I really appreciate the effort to make and send out
> these cleanups. From the initial skim it all looks great (though, some
> are slightly embarrassing :), and I think some of the extra config
> args will be quite nice for others to use as well.
>
> Acked-by: John Stultz <[email protected]>
>
> Thanks so much for submitting these.
> -john
>

Thank you both. I can queue these for 5.20-rc1

Wolfram, are you going to send v2 to address John's comment on
8/9?

thanks,
-- Shuah

2022-07-14 11:46:43

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 0/9] selftests: timers: fixes and improvements

Hey John,

> Acked-by: John Stultz <[email protected]>
>
> Thanks so much for submitting these.

Glad you like this series. I will wait some more to see if there are
further review comments. But surely, I will add the missing parameter to
the help output and add your tags to v2.

Thank you for doing these tools :)

Wolfram


Attachments:
(No filename) (345.00 B)
signature.asc (849.00 B)
Download all attachments

2022-07-14 18:52:26

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 0/9] selftests: timers: fixes and improvements


> Wolfram, are you going to send v2 to address John's comment on
> 8/9?

Yes, will do!


Attachments:
(No filename) (95.00 B)
signature.asc (849.00 B)
Download all attachments

2022-07-14 21:05:19

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 0/9] selftests: timers: fixes and improvements

On 7/14/22 12:43 PM, Wolfram Sang wrote:
>
>> Wolfram, are you going to send v2 to address John's comment on
>> 8/9?
>
> Yes, will do!
>

All patches now applied to linux-kselftest next for 5.20-rc1

Picked up v1 1-7 and 9 and v2 8

thanks,
-- Shuah