2022-07-04 20:06:34

by Christophe JAILLET

Subject: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <[email protected]>
---
net/netfilter/ipvs/ip_vs_mh.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
index da0280cec506..e3d7f5c879ce 100644
--- a/net/netfilter/ipvs/ip_vs_mh.c
+++ b/net/netfilter/ipvs/ip_vs_mh.c
@@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
return 0;
}

- table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
- sizeof(unsigned long), GFP_KERNEL);
+ table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL);
if (!table)
return -ENOMEM;

@@ -227,7 +226,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
}

out:
- kfree(table);
+ bitmap_free(table);
return 0;
}

--
2.34.1

2022-07-05 11:18:33

by Julian Anastasov

Subject: Re: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

Hello,

On Mon, 4 Jul 2022, Christophe JAILLET wrote:

> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Looks good to me for -next! Thanks!

Acked-by: Julian Anastasov <[email protected]>

> ---
> net/netfilter/ipvs/ip_vs_mh.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
> index da0280cec506..e3d7f5c879ce 100644
> --- a/net/netfilter/ipvs/ip_vs_mh.c
> +++ b/net/netfilter/ipvs/ip_vs_mh.c
> @@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
> return 0;
> }
>
> - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
> - sizeof(unsigned long), GFP_KERNEL);
> + table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL);
> if (!table)
> return -ENOMEM;
>
> @@ -227,7 +226,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
> }
>
> out:
> - kfree(table);
> + bitmap_free(table);
> return 0;
> }
>
> --
> 2.34.1

Regards

--
Julian Anastasov <[email protected]>

2022-07-16 09:21:40

by Simon Horman

Subject: Re: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

On Tue, Jul 05, 2022 at 01:05:54PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Mon, 4 Jul 2022, Christophe JAILLET wrote:
>
> > Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
> >
> > It is less verbose and it improves the semantic.
> >
> > Signed-off-by: Christophe JAILLET <[email protected]>
>
> Looks good to me for -next! Thanks!
>
> Acked-by: Julian Anastasov <[email protected]>

Acked-by: Simon Horman <[email protected]>

2022-07-20 23:05:51

by Pablo Neira Ayuso

Subject: Re: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

On Mon, Jul 04, 2022 at 09:24:46PM +0200, Christophe JAILLET wrote:
> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.

Applied to nf-next, thanks