2022-08-15 12:39:46

by Tony Lindgren

Subject: [PATCH] clocksource/drivers/timer-ti-dm: Fix compile test warning

We can get a warning with COMPILE_TEST enabled for omap_timer_match
for 'omap_timer_match' defined but not used.

Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
---
drivers/clocksource/timer-ti-dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -1040,7 +1040,7 @@ static const struct dmtimer_platform_data am6_pdata = {
.timer_ops = &dmtimer_ops,
};

-static const struct of_device_id omap_timer_match[] = {
+static const __maybe_unused struct of_device_id omap_timer_match[] = {
{
.compatible = "ti,omap2420-timer",
},
--
2.37.1

2022-08-15 13:05:00

by Arnd Bergmann

Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix compile test warning

On Mon, Aug 15, 2022 at 2:03 PM Tony Lindgren <[email protected]> wrote:
>
> We can get a warning with COMPILE_TEST enabled for omap_timer_match
> for 'omap_timer_match' defined but not used.
>
> Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Tony Lindgren <[email protected]>
> ---
> drivers/clocksource/timer-ti-dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
> --- a/drivers/clocksource/timer-ti-dm.c
> +++ b/drivers/clocksource/timer-ti-dm.c
> @@ -1040,7 +1040,7 @@ static const struct dmtimer_platform_data am6_pdata = {
> .timer_ops = &dmtimer_ops,
> };
>
> -static const struct of_device_id omap_timer_match[] = {
> +static const __maybe_unused struct of_device_id omap_timer_match[] = {
> {
> .compatible = "ti,omap2420-timer",
> },

I think a better way to address this is to remove the of_match_ptr()
usage from the driver. The only reason to use of_match_ptr() is to save
a few bytes on machines that don't have CONFIG_OF enabled, but this
driver is not used on such machines any more.

Arnd

2022-08-15 13:24:58

by Tony Lindgren

Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix compile test warning

* Arnd Bergmann <[email protected]> [220815 12:48]:
> On Mon, Aug 15, 2022 at 2:03 PM Tony Lindgren <[email protected]> wrote:
> >
> > We can get a warning with COMPILE_TEST enabled for omap_timer_match
> > for 'omap_timer_match' defined but not used.
> >
> > Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Tony Lindgren <[email protected]>
> > ---
> > drivers/clocksource/timer-ti-dm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
> > --- a/drivers/clocksource/timer-ti-dm.c
> > +++ b/drivers/clocksource/timer-ti-dm.c
> > @@ -1040,7 +1040,7 @@ static const struct dmtimer_platform_data am6_pdata = {
> > .timer_ops = &dmtimer_ops,
> > };
> >
> > -static const struct of_device_id omap_timer_match[] = {
> > +static const __maybe_unused struct of_device_id omap_timer_match[] = {
> > {
> > .compatible = "ti,omap2420-timer",
> > },
>
> I think a better way to address this is to remove the of_match_ptr()
> usage from the driver. The only reason to use of_match_ptr() is to save
> a few bytes on machines that don't have CONFIG_OF enabled, but this
> driver is not used on such machines any more.

OK makes sense, will send v2 patch.

Thanks,

Tony