2022-08-30 18:33:57

by Andy Shevchenko

Subject: [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()

There is a convention to use internal kernel types, hence replace
__u8 by u8.

Signed-off-by: Andy Shevchenko <[email protected]>
---
Cc'ed to Andrew since original code authors didn't respond for a month
include/asm-generic/unaligned.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-generic/unaligned.h b/include/asm-generic/unaligned.h
index df30f11b4a46..699650f81970 100644
--- a/include/asm-generic/unaligned.h
+++ b/include/asm-generic/unaligned.h
@@ -126,7 +126,7 @@ static inline void put_unaligned_le24(const u32 val, void *p)
__put_unaligned_le24(val, p);
}

-static inline void __put_unaligned_be48(const u64 val, __u8 *p)
+static inline void __put_unaligned_be48(const u64 val, u8 *p)
{
*p++ = val >> 40;
*p++ = val >> 32;
--
2.35.1

2022-08-31 17:36:52

by Keith Busch

Subject: Re: [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()

On Tue, Aug 30, 2022 at 08:27:13PM +0300, Andy Shevchenko wrote:
> There is a convention to use internal kernel types, hence replace
> __u8 by u8.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Sorry for the delay, looks good.

Reviewed-by: Keith Busch <[email protected]>

2022-09-01 21:20:22

by Andy Shevchenko

Subject: Re: [RESEND][PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()

On Wed, Aug 31, 2022 at 11:01:11AM -0600, Keith Busch wrote:
> On Tue, Aug 30, 2022 at 08:27:13PM +0300, Andy Shevchenko wrote:
> > There is a convention to use internal kernel types, hence replace
> > __u8 by u8.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Sorry for the delay, looks good.
>
> Reviewed-by: Keith Busch <[email protected]>

Thanks!

Andrew, can you pick this up?

--
With Best Regards,
Andy Shevchenko