2022-09-02 09:54:54

by Kumaravel Thiagarajan

[permalink] [raw]
Subject: [PATCH char-misc-testing] misc: microchip: pci1xxxx: fix the build issue due to missing depends on PCI in the Kconfig file.

Some build errors were reported by the kernel test robot
<[email protected]> on the char-misc-testing branch. This add-on patch
will fix those errors.

Fixes: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Kumaravel Thiagarajan <[email protected]>
---
drivers/misc/mchp_pci1xxxx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/misc/mchp_pci1xxxx/Kconfig b/drivers/misc/mchp_pci1xxxx/Kconfig
index 387a88addfb0..f6a6970d2a59 100644
--- a/drivers/misc/mchp_pci1xxxx/Kconfig
+++ b/drivers/misc/mchp_pci1xxxx/Kconfig
@@ -1,5 +1,6 @@
config GP_PCI1XXXX
tristate "Microchip PCI1XXXX PCIe to GPIO Expander + OTP/EEPROM manager"
+ depends on PCI
select GPIOLIB_IRQCHIP
help
PCI1XXXX is a PCIe GEN 3 switch with one of the endpoints having
--
2.25.1


2022-09-02 13:38:47

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH char-misc-testing] misc: microchip: pci1xxxx: fix the build issue due to missing depends on PCI in the Kconfig file.

On Fri, Sep 02, 2022 at 03:20:40PM +0530, Kumaravel Thiagarajan wrote:
> Some build errors were reported by the kernel test robot
> <[email protected]> on the char-misc-testing branch. This add-on patch
> will fix those errors.
>
> Fixes: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Kumaravel Thiagarajan <[email protected]>
> ---
> drivers/misc/mchp_pci1xxxx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/mchp_pci1xxxx/Kconfig b/drivers/misc/mchp_pci1xxxx/Kconfig
> index 387a88addfb0..f6a6970d2a59 100644
> --- a/drivers/misc/mchp_pci1xxxx/Kconfig
> +++ b/drivers/misc/mchp_pci1xxxx/Kconfig
> @@ -1,5 +1,6 @@
> config GP_PCI1XXXX
> tristate "Microchip PCI1XXXX PCIe to GPIO Expander + OTP/EEPROM manager"
> + depends on PCI
> select GPIOLIB_IRQCHIP
> help
> PCI1XXXX is a PCIe GEN 3 switch with one of the endpoints having
> --
> 2.25.1
>

Now merged into the original commit to hopefully prevent the build issues.

thanks,

greg k-h