Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
DMIC power source to match the hardware schematic.
This patch:
1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
setting.
Co-developed-by: Srinivasa Rao Mandadapu <[email protected]>
Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
Signed-off-by: Judy Hsiao <[email protected]>
---
Changes since V3:
-- Update the commit message and fix extra blank line.
Changes since V2:
-- Update the commit message.
Changes since V1:
-- Update the commit message.
This patch depends on:
arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1]
[1] https://patchwork.kernel.org/patch/12929106
.../dts/qcom/sc7280-herobrine-villager-r1.dts | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
index c03b3ae4de50..fd202a8f6a33 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
@@ -12,3 +12,30 @@ / {
model = "Google Villager (rev1+)";
compatible = "google,villager", "qcom,sc7280";
};
+
+&lpass_va_macro {
+ vdd-micb-supply = <&pp1800_l2c>;
+};
+
+&sound {
+ audio-routing =
+ "IN1_HPHL", "HPHL_OUT",
+ "IN2_HPHR", "HPHR_OUT",
+ "AMIC1", "MIC BIAS1",
+ "AMIC2", "MIC BIAS2",
+ "VA DMIC0", "vdd-micb",
+ "VA DMIC1", "vdd-micb",
+ "VA DMIC2", "vdd-micb",
+ "VA DMIC3", "vdd-micb",
+ "TX SWR_ADC0", "ADC1_OUTPUT",
+ "TX SWR_ADC1", "ADC2_OUTPUT",
+ "TX SWR_ADC2", "ADC3_OUTPUT",
+ "TX SWR_DMIC0", "DMIC1_OUTPUT",
+ "TX SWR_DMIC1", "DMIC2_OUTPUT",
+ "TX SWR_DMIC2", "DMIC3_OUTPUT",
+ "TX SWR_DMIC3", "DMIC4_OUTPUT",
+ "TX SWR_DMIC4", "DMIC5_OUTPUT",
+ "TX SWR_DMIC5", "DMIC6_OUTPUT",
+ "TX SWR_DMIC6", "DMIC7_OUTPUT",
+ "TX SWR_DMIC7", "DMIC8_OUTPUT";
+};
--
2.37.2.672.g94769d06f0-goog
Quoting Judy Hsiao (2022-08-25 23:56:21)
> Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> DMIC power source to match the hardware schematic.
>
> This patch:
> 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> setting.
>
> Co-developed-by: Srinivasa Rao Mandadapu <[email protected]>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Signed-off-by: Judy Hsiao <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> index c03b3ae4de50..fd202a8f6a33 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> @@ -12,3 +12,30 @@ / {
> model = "Google Villager (rev1+)";
> compatible = "google,villager", "qcom,sc7280";
> };
> +
> +&lpass_va_macro {
> + vdd-micb-supply = <&pp1800_l2c>;
> +};
I wonder if we'll want to move this to some common "lpass audio" mixin
dtsi file, but we can do that later.
Hi,
On Thu, Aug 25, 2022 at 11:56 PM Judy Hsiao <[email protected]> wrote:
>
> Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> DMIC power source to match the hardware schematic.
>
> This patch:
> 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> setting.
>
> Co-developed-by: Srinivasa Rao Mandadapu <[email protected]>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Signed-off-by: Judy Hsiao <[email protected]>
> ---
> Changes since V3:
> -- Update the commit message and fix extra blank line.
> Changes since V2:
> -- Update the commit message.
> Changes since V1:
> -- Update the commit message.
>
> This patch depends on:
> arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1]
>
> [1] https://patchwork.kernel.org/patch/12929106
After applying your [1] then your patch applies without merge
conflicts. However, it still doesn't compile. You also depend on
whatever patch adds the nodes "lpass_va_macro" and "sound" since
you're referencing them in your patch. I haven't been keeping track of
the latest status of all the audio patches, so I myself can't point to
exactly what patches you depend on and whether those patches are ready
to land.
In any case, the contents of this patch seem OK assuming the dependent
patches cause something that looks like the current (downstream)
chromeos-5.15 tree.
Reviewed-by: Douglas Anderson <[email protected]>
On Fri, Aug 26, 2022 at 10:14:58AM -0700, Doug Anderson wrote:
> Hi,
>
> On Thu, Aug 25, 2022 at 11:56 PM Judy Hsiao <[email protected]> wrote:
> >
> > Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> > DMIC power source to match the hardware schematic.
> >
> > This patch:
> > 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> > 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> > setting.
> >
> > Co-developed-by: Srinivasa Rao Mandadapu <[email protected]>
> > Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> > Signed-off-by: Judy Hsiao <[email protected]>
> > ---
> > Changes since V3:
> > -- Update the commit message and fix extra blank line.
> > Changes since V2:
> > -- Update the commit message.
> > Changes since V1:
> > -- Update the commit message.
> >
> > This patch depends on:
> > arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1]
> >
> > [1] https://patchwork.kernel.org/patch/12929106
>
> After applying your [1] then your patch applies without merge
> conflicts. However, it still doesn't compile. You also depend on
> whatever patch adds the nodes "lpass_va_macro" and "sound" since
> you're referencing them in your patch. I haven't been keeping track of
> the latest status of all the audio patches, so I myself can't point to
> exactly what patches you depend on and whether those patches are ready
> to land.
>
> In any case, the contents of this patch seem OK assuming the dependent
> patches cause something that looks like the current (downstream)
> chromeos-5.15 tree.
>
> Reviewed-by: Douglas Anderson <[email protected]>
To my best knowledge the dependencies of the audio mess are (roughly in
order):
Add support for audio clock gating resets for SC7280 (v8)
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=671887
ready to land? (patch 2 has a minor comment about SoB tag)
Add DT support for audio clock gating resets for SC7280 (v4)
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=666480
ready to land after dependencies land
Add soundcard support for sc7280 based platforms (v14)
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=657417
ready to land after dependencies land
Add dtsi for sc7280 herobrine boards that using rt5682 codec (v3)
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=644812
ready to land after dependencies land
Add new board revision and LTE SKUs for sc7280-villager family (v8)
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=663014
ready to land after dependencies land
arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1 (v4)
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/
ready to land after dependencies land
So it looks like things are generally ready to land, unless [1] needs a
re-spin to fix the SoB tag.
m.
[1] https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/
On Mon, Aug 29, 2022 at 03:20:53PM -0700, Matthias Kaehlcke wrote:
> On Fri, Aug 26, 2022 at 10:14:58AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, Aug 25, 2022 at 11:56 PM Judy Hsiao <[email protected]> wrote:
> > >
> > > Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> > > DMIC power source to match the hardware schematic.
> > >
> > > This patch:
> > > 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> > > 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> > > setting.
> > >
> > > Co-developed-by: Srinivasa Rao Mandadapu <[email protected]>
> > > Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> > > Signed-off-by: Judy Hsiao <[email protected]>
> > > ---
> > > Changes since V3:
> > > -- Update the commit message and fix extra blank line.
> > > Changes since V2:
> > > -- Update the commit message.
> > > Changes since V1:
> > > -- Update the commit message.
> > >
> > > This patch depends on:
> > > arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1]
> > >
> > > [1] https://patchwork.kernel.org/patch/12929106
> >
> > After applying your [1] then your patch applies without merge
> > conflicts. However, it still doesn't compile. You also depend on
> > whatever patch adds the nodes "lpass_va_macro" and "sound" since
> > you're referencing them in your patch. I haven't been keeping track of
> > the latest status of all the audio patches, so I myself can't point to
> > exactly what patches you depend on and whether those patches are ready
> > to land.
> >
> > In any case, the contents of this patch seem OK assuming the dependent
> > patches cause something that looks like the current (downstream)
> > chromeos-5.15 tree.
> >
> > Reviewed-by: Douglas Anderson <[email protected]>
>
> To my best knowledge the dependencies of the audio mess are (roughly in
> order):
>
> Add support for audio clock gating resets for SC7280 (v8)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=671887
> ready to land? (patch 2 has a minor comment about SoB tag)
The comment has been addressed in v9:
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=673055
So it seems all the audio bits should be ready to land.
Satya: please make sure to include change logs in all future patches to
help reviewers understand what changed in each version.
> Add DT support for audio clock gating resets for SC7280 (v4)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=666480
> ready to land after dependencies land
>
> Add soundcard support for sc7280 based platforms (v14)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=657417
> ready to land after dependencies land
>
> Add dtsi for sc7280 herobrine boards that using rt5682 codec (v3)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=644812
> ready to land after dependencies land
>
> Add new board revision and LTE SKUs for sc7280-villager family (v8)
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=663014
> ready to land after dependencies land
>
> arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1 (v4)
> https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/
> ready to land after dependencies land
>
> So it looks like things are generally ready to land, unless [1] needs a
> re-spin to fix the SoB tag.
>
> m.
>
> [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/
Hi Matthias,
On 9/7/2022 9:16 PM, Matthias Kaehlcke wrote:
>
>> Add support for audio clock gating resets for SC7280 (v8)
>> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=671887
>> ready to land? (patch 2 has a minor comment about SoB tag)
> The comment has been addressed in v9:
>
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=673055
>
> So it seems all the audio bits should be ready to land.
>
> Satya: please make sure to include change logs in all future patches to
> help reviewers understand what changed in each version.
I have added the change log in the cover letter, I'll add it to all the
patches of series from next time.
Thanks,
Satya Priya
On Fri, 26 Aug 2022 06:56:21 +0000, Judy Hsiao wrote:
> Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> DMIC power source to match the hardware schematic.
>
> This patch:
> 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> setting.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1
commit: 61a301ca83736afeeeb307b931c59f107067da3c
Best regards,
--
Bjorn Andersson <[email protected]>
On Fri, Aug 26, 2022 at 06:56:21AM +0000, Judy Hsiao wrote:
> Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> DMIC power source to match the hardware schematic.
>
> This patch:
> 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> setting.
>
> Co-developed-by: Srinivasa Rao Mandadapu <[email protected]>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Signed-off-by: Judy Hsiao <[email protected]>
> ---
> Changes since V3:
> -- Update the commit message and fix extra blank line.
> Changes since V2:
> -- Update the commit message.
> Changes since V1:
> -- Update the commit message.
>
> This patch depends on:
> arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1]
>
> [1] https://patchwork.kernel.org/patch/12929106
With [1] applied this patch applies cleanly, but it doesn't built.
What am I missing?
Regards,
Bjorn
>
> .../dts/qcom/sc7280-herobrine-villager-r1.dts | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> index c03b3ae4de50..fd202a8f6a33 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> @@ -12,3 +12,30 @@ / {
> model = "Google Villager (rev1+)";
> compatible = "google,villager", "qcom,sc7280";
> };
> +
> +&lpass_va_macro {
> + vdd-micb-supply = <&pp1800_l2c>;
> +};
> +
> +&sound {
> + audio-routing =
> + "IN1_HPHL", "HPHL_OUT",
> + "IN2_HPHR", "HPHR_OUT",
> + "AMIC1", "MIC BIAS1",
> + "AMIC2", "MIC BIAS2",
> + "VA DMIC0", "vdd-micb",
> + "VA DMIC1", "vdd-micb",
> + "VA DMIC2", "vdd-micb",
> + "VA DMIC3", "vdd-micb",
> + "TX SWR_ADC0", "ADC1_OUTPUT",
> + "TX SWR_ADC1", "ADC2_OUTPUT",
> + "TX SWR_ADC2", "ADC3_OUTPUT",
> + "TX SWR_DMIC0", "DMIC1_OUTPUT",
> + "TX SWR_DMIC1", "DMIC2_OUTPUT",
> + "TX SWR_DMIC2", "DMIC3_OUTPUT",
> + "TX SWR_DMIC3", "DMIC4_OUTPUT",
> + "TX SWR_DMIC4", "DMIC5_OUTPUT",
> + "TX SWR_DMIC5", "DMIC6_OUTPUT",
> + "TX SWR_DMIC6", "DMIC7_OUTPUT",
> + "TX SWR_DMIC7", "DMIC8_OUTPUT";
> +};
> --
> 2.37.2.672.g94769d06f0-goog
>
Please help to apply
Add dtsi for sc7280 herobrine boards that using rt5682 codec (v4)
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=661760
It's dependencies are landed.
Thanks & Regards
On Tue, Sep 13, 2022 at 11:04 PM Bjorn Andersson <[email protected]> wrote:
>
> On Fri, 26 Aug 2022 06:56:21 +0000, Judy Hsiao wrote:
> > Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> > DMIC power source to match the hardware schematic.
> >
> > This patch:
> > 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> > 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> > setting.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1
> commit: 61a301ca83736afeeeb307b931c59f107067da3c
>
> Best regards,
> --
> Bjorn Andersson <[email protected]>