2022-08-01 09:08:11

by Li zeming

Subject: [PATCH] proc: remove initialization assignment

The allocation address of the core_parent pointer variable is first
executed in the function, no initialization assignment is required.

Signed-off-by: Li zeming <[email protected]>
---
fs/proc/proc_sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 021e83fe831f..50ba9e4fb284 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -1246,7 +1246,7 @@ static bool get_links(struct ctl_dir *dir,
static int insert_links(struct ctl_table_header *head)
{
struct ctl_table_set *root_set = &sysctl_table_root.default_set;
- struct ctl_dir *core_parent = NULL;
+ struct ctl_dir *core_parent;
struct ctl_table_header *links;
int err;

--
2.18.2

2022-09-09 00:14:09

by Luis Chamberlain

Subject: Re: [PATCH] proc: remove initialization assignment

On Mon, Aug 01, 2022 at 04:51:17PM +0800, Li zeming wrote:
> The allocation address of the core_parent pointer variable is first
> executed in the function, no initialization assignment is required.
>
> Signed-off-by: Li zeming <[email protected]>

Thanks!

Queued up for sysctl-testing, if that comes back without issues, I'll
move it to sysctl-next.

Luis