2022-09-21 02:30:45

by CGEL

Subject: [PATCH] xen-netback: use kstrdup instead of open-coding it

From: Minghao Chi <[email protected]>

use kstrdup instead of open-coding it.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/net/xen-netback/xenbus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index e85b3c5d4acc..c1ba4294f364 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -865,13 +865,12 @@ static int connect_data_rings(struct backend_info *be,
* queue-N.
*/
if (num_queues == 1) {
- xspath = kzalloc(strlen(dev->otherend) + 1, GFP_KERNEL);
+ xspath = kstrdup(dev->otherend, GFP_KERNEL);
if (!xspath) {
xenbus_dev_fatal(dev, -ENOMEM,
"reading ring references");
return -ENOMEM;
}
- strcpy(xspath, dev->otherend);
} else {
xspathsize = strlen(dev->otherend) + xenstore_path_ext_size;
xspath = kzalloc(xspathsize, GFP_KERNEL);
--
2.25.1

2022-09-23 11:23:07

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] xen-netback: use kstrdup instead of open-coding it

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Wed, 21 Sep 2022 02:16:17 +0000 you wrote:
> From: Minghao Chi <[email protected]>
>
> use kstrdup instead of open-coding it.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
>
> [...]

Here is the summary with links:
- xen-netback: use kstrdup instead of open-coding it
https://git.kernel.org/netdev/net-next/c/f948ac231333

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2022-09-23 11:37:12

by Wei Liu

Subject: Re: [PATCH] xen-netback: use kstrdup instead of open-coding it

On Wed, Sep 21, 2022 at 02:16:17AM +0000, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> use kstrdup instead of open-coding it.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>

Acked-by: Wei Liu <[email protected]>