2022-09-13 17:57:53

by Steve Wahl

[permalink] [raw]
Subject: Re: [PATCH v2] drivers/misc/sgi-xp: Remove orphan declarations from drivers/misc/sgi-xp/xp.h

Reviewed-by: Steve Wahl <[email protected]>

On Tue, Sep 13, 2022 at 07:03:56PM +0800, Gaosheng Cui wrote:
> Remove the following orphan declarations from drivers/misc/sgi-xp/xp.h:
> 1. xp_nofault_PIOR_target
> 2. xp_error_PIOR
> 3. xp_nofault_PIOR
>
> They have been removed since commit 9726bfcdb977 ("misc/sgi-xp:
> remove SGI SN2 support"), so remove them.
>
> Signed-off-by: Gaosheng Cui <[email protected]>
> ---
> v2:
> - Remove unused xp_nofault_PIOR declaration.
> - Format the commit messages for the patch, thanks!
> drivers/misc/sgi-xp/xp.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/misc/sgi-xp/xp.h b/drivers/misc/sgi-xp/xp.h
> index 9f9af77f8d2e..f1336f43d3bd 100644
> --- a/drivers/misc/sgi-xp/xp.h
> +++ b/drivers/misc/sgi-xp/xp.h
> @@ -334,10 +334,6 @@ extern int (*xp_cpu_to_nasid) (int);
> extern enum xp_retval (*xp_expand_memprotect) (unsigned long, unsigned long);
> extern enum xp_retval (*xp_restrict_memprotect) (unsigned long, unsigned long);
>
> -extern u64 xp_nofault_PIOR_target;
> -extern int xp_nofault_PIOR(void *);
> -extern int xp_error_PIOR(void);
> -
> extern struct device *xp;
> extern enum xp_retval xp_init_uv(void);
> extern void xp_exit_uv(void);
> --
> 2.25.1
>

--
Steve Wahl, Hewlett Packard Enterprise