2022-09-09 09:29:53

by Miaohe Lin

Subject: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK

Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass
during bulk free"), it's not used anymore. Remove it.

Signed-off-by: Miaohe Lin <[email protected]>
---
include/linux/mmzone.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index d907a29cc429..6950179a20a2 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -569,7 +569,6 @@ enum zone_watermarks {
* in the least significant bits.
*/
#define NR_PCP_ORDER_WIDTH 8
-#define NR_PCP_ORDER_MASK ((1<<NR_PCP_ORDER_WIDTH) - 1)

#define min_wmark_pages(z) (z->_watermark[WMARK_MIN] + z->watermark_boost)
#define low_wmark_pages(z) (z->_watermark[WMARK_LOW] + z->watermark_boost)
--
2.23.0

2022-09-09 11:29:30

by David Hildenbrand

Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK

On 09.09.22 11:24, Miaohe Lin wrote:
> Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass
> during bulk free"), it's not used anymore. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> include/linux/mmzone.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index d907a29cc429..6950179a20a2 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -569,7 +569,6 @@ enum zone_watermarks {
> * in the least significant bits.
> */
> #define NR_PCP_ORDER_WIDTH 8
> -#define NR_PCP_ORDER_MASK ((1<<NR_PCP_ORDER_WIDTH) - 1)
>
> #define min_wmark_pages(z) (z->_watermark[WMARK_MIN] + z->watermark_boost)
> #define low_wmark_pages(z) (z->_watermark[WMARK_LOW] + z->watermark_boost)

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2022-09-09 20:28:40

by Matthew Wilcox

Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK

On Fri, Sep 09, 2022 at 05:24:38PM +0800, Miaohe Lin wrote:
> Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass
> during bulk free"), it's not used anymore. Remove it.

Yes, but this patch needs to go further. The comment is no longer true
(after the patch you mention), so need to also delete these lines:

-/*
- * Shift to encode migratetype and order in the same integer, with order
- * in the least significant bits.
- */
-#define NR_PCP_ORDER_WIDTH 8

and the line:
- BUILD_BUG_ON(MAX_ORDER >= (1<<NR_PCP_ORDER_WIDTH));

2022-09-13 03:43:26

by Miaohe Lin

Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK

On 2022/9/10 3:37, Matthew Wilcox wrote:
> On Fri, Sep 09, 2022 at 05:24:38PM +0800, Miaohe Lin wrote:
>> Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass
>> during bulk free"), it's not used anymore. Remove it.
>
> Yes, but this patch needs to go further. The comment is no longer true
> (after the patch you mention), so need to also delete these lines:
>
> -/*
> - * Shift to encode migratetype and order in the same integer, with order
> - * in the least significant bits.
> - */
> -#define NR_PCP_ORDER_WIDTH 8
>
> and the line:
> - BUILD_BUG_ON(MAX_ORDER >= (1<<NR_PCP_ORDER_WIDTH));
>

Agree. Many thanks for pointing this out. Will do it in next version.

Thanks,
Miaohe Lin

>
> .
>

2022-09-13 08:23:22

by Anshuman Khandual

Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK

On 9/9/22 14:54, Miaohe Lin wrote:
> Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass
> during bulk free"), it's not used anymore. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>

With those additional changes suggested by Matthew earlier

Reviewed-by: Anshuman Khandual <[email protected]>

> ---
> include/linux/mmzone.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index d907a29cc429..6950179a20a2 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -569,7 +569,6 @@ enum zone_watermarks {
> * in the least significant bits.
> */
> #define NR_PCP_ORDER_WIDTH 8
> -#define NR_PCP_ORDER_MASK ((1<<NR_PCP_ORDER_WIDTH) - 1)
>
> #define min_wmark_pages(z) (z->_watermark[WMARK_MIN] + z->watermark_boost)
> #define low_wmark_pages(z) (z->_watermark[WMARK_LOW] + z->watermark_boost)

2022-09-15 05:52:10

by Oscar Salvador

Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK

On Fri, Sep 09, 2022 at 05:24:38PM +0800, Miaohe Lin wrote:
> Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass
> during bulk free"), it's not used anymore. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>

with the changes from Matthew applied:

Reviewed-by: Oscar Salvador <[email protected]>

> ---
> include/linux/mmzone.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index d907a29cc429..6950179a20a2 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -569,7 +569,6 @@ enum zone_watermarks {
> * in the least significant bits.
> */
> #define NR_PCP_ORDER_WIDTH 8
> -#define NR_PCP_ORDER_MASK ((1<<NR_PCP_ORDER_WIDTH) - 1)
>
> #define min_wmark_pages(z) (z->_watermark[WMARK_MIN] + z->watermark_boost)
> #define low_wmark_pages(z) (z->_watermark[WMARK_LOW] + z->watermark_boost)
> --
> 2.23.0
>
>

--
Oscar Salvador
SUSE Labs