2022-09-09 09:30:22

by Miaohe Lin

Subject: [PATCH 07/16] mm: remove obsolete pgdat_is_empty()

There's no caller. Remove it.

Signed-off-by: Miaohe Lin <[email protected]>
---
include/linux/mmzone.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 6950179a20a2..ab17a0e6f26f 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -1247,11 +1247,6 @@ static inline unsigned long pgdat_end_pfn(pg_data_t *pgdat)
return pgdat->node_start_pfn + pgdat->node_spanned_pages;
}

-static inline bool pgdat_is_empty(pg_data_t *pgdat)
-{
- return !pgdat->node_start_pfn && !pgdat->node_spanned_pages;
-}
-
#include <linux/memory_hotplug.h>

void build_all_zonelists(pg_data_t *pgdat);
--
2.23.0

2022-09-09 12:03:35

by David Hildenbrand

Subject: Re: [PATCH 07/16] mm: remove obsolete pgdat_is_empty()

On 09.09.22 11:24, Miaohe Lin wrote:
> There's no caller. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> include/linux/mmzone.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 6950179a20a2..ab17a0e6f26f 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1247,11 +1247,6 @@ static inline unsigned long pgdat_end_pfn(pg_data_t *pgdat)
> return pgdat->node_start_pfn + pgdat->node_spanned_pages;
> }
>
> -static inline bool pgdat_is_empty(pg_data_t *pgdat)
> -{
> - return !pgdat->node_start_pfn && !pgdat->node_spanned_pages;
> -}
> -
> #include <linux/memory_hotplug.h>
>
> void build_all_zonelists(pg_data_t *pgdat);

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2022-09-13 09:30:30

by Anshuman Khandual

Subject: Re: [PATCH 07/16] mm: remove obsolete pgdat_is_empty()

On 9/9/22 14:54, Miaohe Lin wrote:
> There's no caller. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Anshuman Khandual <[email protected]>

> ---
> include/linux/mmzone.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 6950179a20a2..ab17a0e6f26f 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1247,11 +1247,6 @@ static inline unsigned long pgdat_end_pfn(pg_data_t *pgdat)
> return pgdat->node_start_pfn + pgdat->node_spanned_pages;
> }
>
> -static inline bool pgdat_is_empty(pg_data_t *pgdat)
> -{
> - return !pgdat->node_start_pfn && !pgdat->node_spanned_pages;
> -}
> -
> #include <linux/memory_hotplug.h>
>
> void build_all_zonelists(pg_data_t *pgdat);

2022-09-15 05:03:51

by Oscar Salvador

Subject: Re: [PATCH 07/16] mm: remove obsolete pgdat_is_empty()

On Fri, Sep 09, 2022 at 05:24:42PM +0800, Miaohe Lin wrote:
> There's no caller. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Oscar Salvador <[email protected]>



--
Oscar Salvador
SUSE Labs