2022-09-26 15:59:21

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()

On Fri, Sep 23, 2022 at 06:34:48AM +0000, [email protected] wrote:
> Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of
> scnprintf()
> From: ye xingchen <[email protected]>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/video/backlight/lm3533_bl.c | 10 +++++-----

Looks like a good change but the topic tag ('backlight:') looks a bit
generic for something that only impacts the lm3533_bl.c driver.

Also it would be good if this patchset included the same fix
for *all* drivers that a grep shows contain this code pattern
(e.g. git grep 'return scnprintf.*PAGE_SIZE').


Daniel.