2022-09-27 11:22:08

by Zhang Qiao

[permalink] [raw]
Subject: [PATCH -next] android: binder: Remove comments about tsk fields

Commit a0c2baaf81bd ("android: binder: Don't get mm
from task") remove the binder_alloc struct's tsk, but
didn't remove the header commment about '@tsk'.
So this patch remove it.

Signed-off-by: Zhang Qiao <[email protected]>
---
drivers/android/binder_alloc.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/android/binder_alloc.h b/drivers/android/binder_alloc.h
index 1e4fd37af5e0..fe0738fb9c8c 100644
--- a/drivers/android/binder_alloc.h
+++ b/drivers/android/binder_alloc.h
@@ -76,8 +76,6 @@ struct binder_lru_page {
* struct binder_alloc - per-binder proc state for binder allocator
* @vma: vm_area_struct passed to mmap_handler
* (invarient after mmap)
- * @tsk: tid for task that called init for this proc
- * (invariant after init)
* @vma_vm_mm: copy of vma->vm_mm (invarient after mmap)
* @buffer: base of per-proc address space mapped via mmap
* @buffers: list of all buffers for this proc
--
2.17.1


2022-09-27 18:15:12

by Carlos Llamas

[permalink] [raw]
Subject: Re: [PATCH -next] android: binder: Remove comments about tsk fields

On Wed, Sep 28, 2022 at 08:46:10AM +0800, Zhang Qiao wrote:
> Commit a0c2baaf81bd ("android: binder: Don't get mm
> from task") remove the binder_alloc struct's tsk, but
> didn't remove the header commment about '@tsk'.
> So this patch remove it.
>
> Signed-off-by: Zhang Qiao <[email protected]>
> ---
> drivers/android/binder_alloc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/android/binder_alloc.h b/drivers/android/binder_alloc.h
> index 1e4fd37af5e0..fe0738fb9c8c 100644
> --- a/drivers/android/binder_alloc.h
> +++ b/drivers/android/binder_alloc.h
> @@ -76,8 +76,6 @@ struct binder_lru_page {
> * struct binder_alloc - per-binder proc state for binder allocator
> * @vma: vm_area_struct passed to mmap_handler
> * (invarient after mmap)
> - * @tsk: tid for task that called init for this proc
> - * (invariant after init)
> * @vma_vm_mm: copy of vma->vm_mm (invarient after mmap)
> * @buffer: base of per-proc address space mapped via mmap
> * @buffers: list of all buffers for this proc
> --
> 2.17.1
>

Thanks but this has already been addressed here:
https://git.kernel.org/next/linux-next/c/7b0dbd940765
--
Carlos Llamas