2022-09-28 15:23:26

by haoxin

Subject: [PATCH] x86/mm/tlb: fix error word 'clleared' to 'cleared'

Just correct the wrong word 'clleared' to 'cleared'

Fixes: c9fe66560bf2 ("mm/mprotect: do not flush when not required architecturally")
Signed-off-by: Xin Hao <[email protected]>
---
arch/x86/include/asm/tlbflush.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
index cda3118f3b27..c80a15ef0cbc 100644
--- a/arch/x86/include/asm/tlbflush.h
+++ b/arch/x86/include/asm/tlbflush.h
@@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
diff &= ~_PAGE_ACCESSED;

/*
- * Did any of the 'flush_on_clear' flags was clleared set from between
+ * Did any of the 'flush_on_clear' flags was cleared set from between
* 'oldflags' and 'newflags'?
*/
if (diff & oldflags & flush_on_clear)
--
2.31.0

2022-09-29 09:23:57

by Peter Zijlstra

Subject: Re: [PATCH] x86/mm/tlb: fix error word 'clleared' to 'cleared'

On Wed, Sep 28, 2022 at 11:11:09PM +0800, Xin Hao wrote:
> Just correct the wrong word 'clleared' to 'cleared'
>
> Fixes: c9fe66560bf2 ("mm/mprotect: do not flush when not required architecturally")

Please, don't ever use Fixes on a comment.

2022-09-29 09:33:53

by haoxin

Subject: Re: [PATCH] x86/mm/tlb: fix error word 'clleared' to 'cleared'

在 2022/9/29 下午4:52, Peter Zijlstra 写道:
> On Wed, Sep 28, 2022 at 11:11:09PM +0800, Xin Hao wrote:
>> Just correct the wrong word 'clleared' to 'cleared'
>>
>> Fixes: c9fe66560bf2 ("mm/mprotect: do not flush when not required architecturally")
> Please, don't ever use Fixes on a comment.
Get it, Thanks.