The size of the UFS PHY serdes register region is 0x1c8 and the
corresponding 'reg' property should specifically not include the
adjacent regions that are defined in the child node (e.g. tx and rx).
Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
Signed-off-by: Johan Hovold <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 4b85c9276435..638317f78ab2 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -1432,7 +1432,7 @@ ufs_mem_hc: ufs@1d84000 {
ufs_mem_phy: phy@1d87000 {
compatible = "qcom,sc8280xp-qmp-ufs-phy";
- reg = <0 0x01d87000 0 0xe10>;
+ reg = <0 0x01d87000 0 0x1c8>;
#address-cells = <2>;
#size-cells = <2>;
ranges;
@@ -1500,7 +1500,7 @@ ufs_card_hc: ufs@1da4000 {
ufs_card_phy: phy@1da7000 {
compatible = "qcom,sc8280xp-qmp-ufs-phy";
- reg = <0 0x01da7000 0 0xe10>;
+ reg = <0 0x01da7000 0 0x1c8>;
#address-cells = <2>;
#size-cells = <2>;
ranges;
--
2.35.1
On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> The size of the UFS PHY serdes register region is 0x1c8 and the
> corresponding 'reg' property should specifically not include the
> adjacent regions that are defined in the child node (e.g. tx and rx).
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Johan Hovold <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 4b85c9276435..638317f78ab2 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1432,7 +1432,7 @@ ufs_mem_hc: ufs@1d84000 {
>
> ufs_mem_phy: phy@1d87000 {
> compatible = "qcom,sc8280xp-qmp-ufs-phy";
> - reg = <0 0x01d87000 0 0xe10>;
> + reg = <0 0x01d87000 0 0x1c8>;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> @@ -1500,7 +1500,7 @@ ufs_card_hc: ufs@1da4000 {
>
> ufs_card_phy: phy@1da7000 {
> compatible = "qcom,sc8280xp-qmp-ufs-phy";
> - reg = <0 0x01da7000 0 0xe10>;
> + reg = <0 0x01da7000 0 0x1c8>;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> --
> 2.35.1
>
On Thu, Sep 15, 2022 at 10:09:07AM -0500, Bjorn Andersson wrote:
> On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> > The size of the UFS PHY serdes register region is 0x1c8 and the
> > corresponding 'reg' property should specifically not include the
> > adjacent regions that are defined in the child node (e.g. tx and rx).
> >
> > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > Signed-off-by: Johan Hovold <[email protected]>
>
> Reviewed-by: Bjorn Andersson <[email protected]>
I can't seem to find this one in either the arm64-for-6.1 or fixes
branch for 6.0. Did you just forget to push it?
Johan
On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> The size of the UFS PHY serdes register region is 0x1c8 and the
> corresponding 'reg' property should specifically not include the
> adjacent regions that are defined in the child node (e.g. tx and rx).
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Johan Hovold <[email protected]>
This fixes an issue that I'm seeing on the QDrive3 in next-20220930.
Reviewed-by: Brian Masney <[email protected]>
On Mon, Oct 03, 2022 at 01:46:29PM -0400, Brian Masney wrote:
> On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> > The size of the UFS PHY serdes register region is 0x1c8 and the
> > corresponding 'reg' property should specifically not include the
> > adjacent regions that are defined in the child node (e.g. tx and rx).
> >
> > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > Signed-off-by: Johan Hovold <[email protected]>
>
> This fixes an issue that I'm seeing on the QDrive3 in next-20220930.
>
> Reviewed-by: Brian Masney <[email protected]>
>
Tested-by: Andrew Halaney <[email protected]> #Qdrive3/sa8540p-adp-ride
On Thu, 15 Sep 2022 16:16:01 +0200, Johan Hovold wrote:
> The size of the UFS PHY serdes register region is 0x1c8 and the
> corresponding 'reg' property should specifically not include the
> adjacent regions that are defined in the child node (e.g. tx and rx).
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
commit: 8703d55bd5eac642275fe91b34ac62ad0ad312b5
Best regards,
--
Bjorn Andersson <[email protected]>