According to commit 7945f929f1a7 ("drivers: provide
devm_platform_ioremap_resource()"), convert platform_get_resource(),
devm_ioremap_resource() to a single call to Use
devm_platform_ioremap_resource(), as this is exactly what this function
does.
Signed-off-by: Yang Li <[email protected]>
---
drivers/thermal/rcar_thermal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index b8571f7090aa..ee2dde1fbe2a 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -435,9 +435,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
* Then, driver uses common registers
* rcar_has_irq_support() will be enabled
*/
- res = platform_get_resource(pdev, IORESOURCE_MEM,
- mres++);
- common->base = devm_ioremap_resource(dev, res);
+ common->base = devm_platform_ioremap_resource(pdev, mres++);
if (IS_ERR(common->base)) {
ret = PTR_ERR(common->base);
goto error_unregister;
--
2.20.1.7.g153144c
Hi Yang,
On Wed, Mar 8, 2023 at 7:17 AM Yang Li <[email protected]> wrote:
> According to commit 7945f929f1a7 ("drivers: provide
> devm_platform_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to Use
> devm_platform_ioremap_resource(), as this is exactly what this function
> does.
Thanks for your patch!
> Signed-off-by: Yang Li <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -435,9 +435,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
> * Then, driver uses common registers
> * rcar_has_irq_support() will be enabled
> */
> - res = platform_get_resource(pdev, IORESOURCE_MEM,
> - mres++);
> - common->base = devm_ioremap_resource(dev, res);
> + common->base = devm_platform_ioremap_resource(pdev, mres++);
> if (IS_ERR(common->base)) {
> ret = PTR_ERR(common->base);
> goto error_unregister;
Note that there is a second opportunity for conversion in the same
function, a few lines below.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
> Note that there is a second opportunity for conversion in the same
> function, a few lines below.
This should be fixed in a V2, then, not in an incremental patch, please.