2023-03-06 22:48:48

by Andrew Davis

[permalink] [raw]
Subject: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

As a follow up to the series allowing DTB overlays to built from .dtso
files. Now that all overlays have been renamed, remove the ability to
build from overlays from .dts files to prevent any files with the old
name from accidental being added.

Signed-off-by: Andrew Davis <[email protected]>
---
scripts/Makefile.lib | 3 ---
1 file changed, 3 deletions(-)

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 100a386fcd71..68d0134bdbf9 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -418,9 +418,6 @@ endif
$(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
$(call if_changed_dep,dtb)

-$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
- $(call if_changed_dep,dtc)
-
$(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
$(call if_changed_dep,dtc)

--
2.39.2



2023-03-07 02:37:44

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

On Tue, Mar 7, 2023 at 7:48 AM Andrew Davis <[email protected]> wrote:
>
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <[email protected]>

Acked-by: Masahiro Yamada <[email protected]>

if Rob picks this up.


> ---
> scripts/Makefile.lib | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(call if_changed_dep,dtb)
>
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> - $(call if_changed_dep,dtc)
> -
> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> --
> 2.39.2
>


--
Best Regards
Masahiro Yamada

2023-03-07 07:59:32

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

On Mon, Mar 6, 2023 at 11:48 PM Andrew Davis <[email protected]> wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-03-07 11:55:58

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

On Mon, Mar 06, 2023 at 04:47:52PM -0600, Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.

Since in the past I had a problem with unnecessary rebuilding, this removes
the rule, so should not bring a similar regression.

Acked-by: Andy Shevchenko <[email protected]>

Thank you.

> Signed-off-by: Andrew Davis <[email protected]>
> ---
> scripts/Makefile.lib | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(call if_changed_dep,dtb)
>
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> - $(call if_changed_dep,dtc)
> -
> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> --
> 2.39.2
>

--
With Best Regards,
Andy Shevchenko



2023-03-08 17:04:04

by Andrew Davis

[permalink] [raw]
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

On 3/8/23 10:56 AM, Nicolas Schier wrote:
> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
>> As a follow up to the series allowing DTB overlays to built from .dtso
>> files. Now that all overlays have been renamed, remove the ability to
>> build from overlays from .dts files to prevent any files with the old
> ^^^^
>
> The first "from" sounds superfluous to me.
>

It is a typo, feel free to drop it locally whoever takes this patch.

Thanks,
Andrew

> Kind regards,
> Nicolas
>> name from accidental being added.
>>
>> Signed-off-by: Andrew Davis <[email protected]>
>> ---
>> scripts/Makefile.lib | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 100a386fcd71..68d0134bdbf9 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -418,9 +418,6 @@ endif
>> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>> $(call if_changed_dep,dtb)
>>
>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
>> - $(call if_changed_dep,dtc)
>> -
>> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>> $(call if_changed_dep,dtc)
>>
>> --
>> 2.39.2
>

2023-03-08 17:05:53

by Nicolas Schier

[permalink] [raw]
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
^^^^

The first "from" sounds superfluous to me.

Kind regards,
Nicolas
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <[email protected]>
> ---
> scripts/Makefile.lib | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(call if_changed_dep,dtb)
>
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> - $(call if_changed_dep,dtc)
> -
> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> --
> 2.39.2

--
epost|xmpp: [email protected] irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --

2023-05-15 17:34:37

by Andrew Davis

[permalink] [raw]
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

On 3/8/23 9:01 AM, Andrew Davis wrote:
> On 3/8/23 10:56 AM, Nicolas Schier wrote:
>> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
>>> As a follow up to the series allowing DTB overlays to built from .dtso
>>> files. Now that all overlays have been renamed, remove the ability to
>>> build from overlays from .dts files to prevent any files with the old
>>          ^^^^
>>
>> The first "from" sounds superfluous to me.
>>
>
> It is a typo, feel free to drop it locally whoever takes this patch.
>

Seems no one took this last cycle.. Still valid and applies for this one.

Andrew

> Thanks,
> Andrew
>
>> Kind regards,
>> Nicolas
>>> name from accidental being added.
>>>
>>> Signed-off-by: Andrew Davis <[email protected]>
>>> ---
>>>   scripts/Makefile.lib | 3 ---
>>>   1 file changed, 3 deletions(-)
>>>
>>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>>> index 100a386fcd71..68d0134bdbf9 100644
>>> --- a/scripts/Makefile.lib
>>> +++ b/scripts/Makefile.lib
>>> @@ -418,9 +418,6 @@ endif
>>>   $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>>>       $(call if_changed_dep,dtb)
>>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
>>> -    $(call if_changed_dep,dtc)
>>> -
>>>   $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>>>       $(call if_changed_dep,dtc)
>>> --
>>> 2.39.2
>>

2023-05-22 01:51:20

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

On Tue, May 16, 2023 at 1:49 AM Andrew Davis <[email protected]> wrote:
>
> On 3/8/23 9:01 AM, Andrew Davis wrote:
> > On 3/8/23 10:56 AM, Nicolas Schier wrote:
> >> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
> >>> As a follow up to the series allowing DTB overlays to built from .dtso
> >>> files. Now that all overlays have been renamed, remove the ability to
> >>> build from overlays from .dts files to prevent any files with the old
> >> ^^^^
> >>
> >> The first "from" sounds superfluous to me.
> >>
> >
> > It is a typo, feel free to drop it locally whoever takes this patch.
> >
>
> Seems no one took this last cycle.. Still valid and applies for this one.


Seems it fell into a crack.

Now applied to linux-kbuild. Thanks.





> Andrew
>
> > Thanks,
> > Andrew
> >
> >> Kind regards,
> >> Nicolas
> >>> name from accidental being added.
> >>>
> >>> Signed-off-by: Andrew Davis <[email protected]>
> >>> ---
> >>> scripts/Makefile.lib | 3 ---
> >>> 1 file changed, 3 deletions(-)
> >>>
> >>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> >>> index 100a386fcd71..68d0134bdbf9 100644
> >>> --- a/scripts/Makefile.lib
> >>> +++ b/scripts/Makefile.lib
> >>> @@ -418,9 +418,6 @@ endif
> >>> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> >>> $(call if_changed_dep,dtb)
> >>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> >>> - $(call if_changed_dep,dtc)
> >>> -
> >>> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> >>> $(call if_changed_dep,dtc)
> >>> --
> >>> 2.39.2
> >>



--
Best Regards
Masahiro Yamada