2023-03-10 04:02:12

by Kloudifold

Subject: [PATCH] staging: fbtft: fixes alignment should match open parenthesis

This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis

Signed-off-by: Kloudifold <[email protected]>
---
drivers/staging/fbtft/fb_tinylcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
index 9469248f2..7d4741c47 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -37,8 +37,8 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xB3, 0x00);
write_reg(par, 0xE5, 0x00);
write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
- write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
- 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+ write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00,
+ 0x00, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
udelay(250);
--
2.39.2

2023-03-10 04:08:00

by Dan Carpenter

Subject: Re: [PATCH] staging: fbtft: fixes alignment should match open parenthesis

On Fri, Mar 10, 2023 at 12:01:21PM +0800, Kloudifold wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
>
> Signed-off-by: Kloudifold <[email protected]>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2..7d4741c47 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -37,8 +37,8 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xB3, 0x00);
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> - write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00,
> + 0x00, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);

The original was obviously deliberate. Just leave it as-is. Checkpatch
is not the king of the world.

regards,
dan carpenter