2023-03-16 09:53:59

by Siddharth Vadapalli

[permalink] [raw]
Subject: [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable

From: Grygorii Strashko <[email protected]>

The CPTS PPS GENf adjustment settings are invalid after it has been
disabled for a while, so reset them.

Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
Signed-off-by: Grygorii Strashko <[email protected]>
Signed-off-by: Siddharth Vadapalli <[email protected]>
---
drivers/net/ethernet/ti/am65-cpts.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
index 16ee9c29cb35..8caf85acbb6a 100644
--- a/drivers/net/ethernet/ti/am65-cpts.c
+++ b/drivers/net/ethernet/ti/am65-cpts.c
@@ -636,6 +636,10 @@ static void am65_cpts_perout_enable_hw(struct am65_cpts *cpts,
val = lower_32_bits(cycles);
am65_cpts_write32(cpts, val, genf[req->index].length);

+ am65_cpts_write32(cpts, 0, genf[req->index].control);
+ am65_cpts_write32(cpts, 0, genf[req->index].ppm_hi);
+ am65_cpts_write32(cpts, 0, genf[req->index].ppm_low);
+
cpts->genf_enable |= BIT(req->index);
} else {
am65_cpts_write32(cpts, 0, genf[req->index].length);
--
2.25.1



2023-03-17 11:27:49

by Roger Quadros

[permalink] [raw]
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable



On 16/03/2023 11:52, Siddharth Vadapalli wrote:
> From: Grygorii Strashko <[email protected]>
>
> The CPTS PPS GENf adjustment settings are invalid after it has been
> disabled for a while, so reset them.
>
> Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
> Signed-off-by: Grygorii Strashko <[email protected]>
> Signed-off-by: Siddharth Vadapalli <[email protected]>

Reviewed-by: Roger Quadros <[email protected]>

2023-03-17 12:30:29

by Michal Swiatkowski

[permalink] [raw]
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable

On Fri, Mar 17, 2023 at 01:27:36PM +0200, Roger Quadros wrote:
>
>
> On 16/03/2023 11:52, Siddharth Vadapalli wrote:
> > From: Grygorii Strashko <[email protected]>
> >
> > The CPTS PPS GENf adjustment settings are invalid after it has been
> > disabled for a while, so reset them.
> >
> > Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
> > Signed-off-by: Grygorii Strashko <[email protected]>
> > Signed-off-by: Siddharth Vadapalli <[email protected]>
>
> Reviewed-by: Roger Quadros <[email protected]>

Small nit for the future: should be [PATCH net] instead of net-next when
You sending fixes.

Looks fine, thanks
Reviewed-by: Michal Swiatkowski <[email protected]>

2023-03-18 05:50:26

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Thu, 16 Mar 2023 15:22:32 +0530 you wrote:
> From: Grygorii Strashko <[email protected]>
>
> The CPTS PPS GENf adjustment settings are invalid after it has been
> disabled for a while, so reset them.
>
> Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
> Signed-off-by: Grygorii Strashko <[email protected]>
> Signed-off-by: Siddharth Vadapalli <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable
https://git.kernel.org/netdev/net/c/3dacc5bb8147

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html