2023-03-20 17:03:12

by Khadija Kamran

Subject: [PATCH] staging: greybus: remove camel case

Several variables and functions were named Camel Case. This resulted in
checks pointed by checkpatch.pl

Avoid camel case by changing names.

Signed-off-by: Khadija Kamran <[email protected]>
---
drivers/staging/iio/addac/adt7316.c | 64 ++++++++++++++---------------
1 file changed, 32 insertions(+), 32 deletions(-)

diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 79467f056a05..49702beeac30 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -672,7 +672,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
adt7316_store_da_high_resolution,
0);

-static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
+static ssize_t adt7316_show_AIN_internal_vref(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -686,7 +686,7 @@ static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
!!(chip->config3 & ADT7516_AIN_IN_VREF));
}

-static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
+static ssize_t adt7316_store_AIN_internal_vref(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -713,9 +713,9 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,
return len;
}

-static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,
- adt7316_show_AIN_internal_Vref,
- adt7316_store_AIN_internal_Vref,
+static IIO_DEVICE_ATTR(AIN_internal_vref, 0644,
+ adt7316_show_AIN_internal_vref,
+ adt7316_store_AIN_internal_vref,
0);

static ssize_t adt7316_show_enable_prop_DACA(struct device *dev,
@@ -796,7 +796,7 @@ static IIO_DEVICE_ATTR(enable_proportion_DACB, 0644,
adt7316_store_enable_prop_DACB,
0);

-static ssize_t adt7316_show_DAC_2Vref_ch_mask(struct device *dev,
+static ssize_t adt7316_show_DAC_2vref_ch_mask(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -807,7 +807,7 @@ static ssize_t adt7316_show_DAC_2Vref_ch_mask(struct device *dev,
chip->dac_config & ADT7316_DA_2VREF_CH_MASK);
}

-static ssize_t adt7316_store_DAC_2Vref_ch_mask(struct device *dev,
+static ssize_t adt7316_store_DAC_2vref_ch_mask(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -834,9 +834,9 @@ static ssize_t adt7316_store_DAC_2Vref_ch_mask(struct device *dev,
return len;
}

-static IIO_DEVICE_ATTR(DAC_2Vref_channels_mask, 0644,
- adt7316_show_DAC_2Vref_ch_mask,
- adt7316_store_DAC_2Vref_ch_mask,
+static IIO_DEVICE_ATTR(DAC_2vref_channels_mask, 0644,
+ adt7316_show_DAC_2vref_ch_mask,
+ adt7316_store_DAC_2vref_ch_mask,
0);

static ssize_t adt7316_show_DAC_update_mode(struct device *dev,
@@ -957,7 +957,7 @@ static IIO_DEVICE_ATTR(update_DAC, 0644,
adt7316_store_update_DAC,
0);

-static ssize_t adt7316_show_DA_AB_Vref_bypass(struct device *dev,
+static ssize_t adt7316_show_DA_AB_vref_bypass(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -968,7 +968,7 @@ static ssize_t adt7316_show_DA_AB_Vref_bypass(struct device *dev,
!!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_AB));
}

-static ssize_t adt7316_store_DA_AB_Vref_bypass(struct device *dev,
+static ssize_t adt7316_store_DA_AB_vref_bypass(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -991,12 +991,12 @@ static ssize_t adt7316_store_DA_AB_Vref_bypass(struct device *dev,
return len;
}

-static IIO_DEVICE_ATTR(DA_AB_Vref_bypass, 0644,
- adt7316_show_DA_AB_Vref_bypass,
- adt7316_store_DA_AB_Vref_bypass,
+static IIO_DEVICE_ATTR(DA_AB_vref_bypass, 0644,
+ adt7316_show_DA_AB_vref_bypass,
+ adt7316_store_DA_AB_vref_bypass,
0);

-static ssize_t adt7316_show_DA_CD_Vref_bypass(struct device *dev,
+static ssize_t adt7316_show_DA_CD_vref_bypass(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1007,7 +1007,7 @@ static ssize_t adt7316_show_DA_CD_Vref_bypass(struct device *dev,
!!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_CD));
}

-static ssize_t adt7316_store_DA_CD_Vref_bypass(struct device *dev,
+static ssize_t adt7316_store_DA_CD_vref_bypass(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1030,12 +1030,12 @@ static ssize_t adt7316_store_DA_CD_Vref_bypass(struct device *dev,
return len;
}

-static IIO_DEVICE_ATTR(DA_CD_Vref_bypass, 0644,
- adt7316_show_DA_CD_Vref_bypass,
- adt7316_store_DA_CD_Vref_bypass,
+static IIO_DEVICE_ATTR(DA_CD_vref_bypass, 0644,
+ adt7316_show_DA_CD_vref_bypass,
+ adt7316_store_DA_CD_vref_bypass,
0);

-static ssize_t adt7316_show_DAC_internal_Vref(struct device *dev,
+static ssize_t adt7316_show_DAC_internal_vref(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -1050,7 +1050,7 @@ static ssize_t adt7316_show_DAC_internal_Vref(struct device *dev,
!!(chip->ldac_config & ADT7316_DAC_IN_VREF));
}

-static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,
+static ssize_t adt7316_store_DAC_internal_vref(struct device *dev,
struct device_attribute *attr,
const char *buf,
size_t len)
@@ -1091,9 +1091,9 @@ static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,
return len;
}

-static IIO_DEVICE_ATTR(DAC_internal_Vref, 0644,
- adt7316_show_DAC_internal_Vref,
- adt7316_store_DAC_internal_Vref,
+static IIO_DEVICE_ATTR(DAC_internal_vref, 0644,
+ adt7316_show_DAC_internal_vref,
+ adt7316_store_DAC_internal_vref,
0);

static ssize_t adt7316_show_ad(struct adt7316_chip_info *chip,
@@ -1653,13 +1653,13 @@ static struct attribute *adt7316_attributes[] = {
&iio_dev_attr_da_high_resolution.dev_attr.attr,
&iio_dev_attr_enable_proportion_DACA.dev_attr.attr,
&iio_dev_attr_enable_proportion_DACB.dev_attr.attr,
- &iio_dev_attr_DAC_2Vref_channels_mask.dev_attr.attr,
+ &iio_dev_attr_DAC_2vref_channels_mask.dev_attr.attr,
&iio_dev_attr_DAC_update_mode.dev_attr.attr,
&iio_dev_attr_all_DAC_update_modes.dev_attr.attr,
&iio_dev_attr_update_DAC.dev_attr.attr,
- &iio_dev_attr_DA_AB_Vref_bypass.dev_attr.attr,
- &iio_dev_attr_DA_CD_Vref_bypass.dev_attr.attr,
- &iio_dev_attr_DAC_internal_Vref.dev_attr.attr,
+ &iio_dev_attr_DA_AB_vref_bypass.dev_attr.attr,
+ &iio_dev_attr_DA_CD_vref_bypass.dev_attr.attr,
+ &iio_dev_attr_DAC_internal_vref.dev_attr.attr,
&iio_dev_attr_VDD.dev_attr.attr,
&iio_dev_attr_in_temp.dev_attr.attr,
&iio_dev_attr_ex_temp.dev_attr.attr,
@@ -1693,15 +1693,15 @@ static struct attribute *adt7516_attributes[] = {
&iio_dev_attr_enable_smbus_timeout.dev_attr.attr,
&iio_dev_attr_powerdown.dev_attr.attr,
&iio_dev_attr_fast_ad_clock.dev_attr.attr,
- &iio_dev_attr_AIN_internal_Vref.dev_attr.attr,
+ &iio_dev_attr_AIN_internal_vref.dev_attr.attr,
&iio_dev_attr_da_high_resolution.dev_attr.attr,
&iio_dev_attr_enable_proportion_DACA.dev_attr.attr,
&iio_dev_attr_enable_proportion_DACB.dev_attr.attr,
- &iio_dev_attr_DAC_2Vref_channels_mask.dev_attr.attr,
+ &iio_dev_attr_DAC_2vref_channels_mask.dev_attr.attr,
&iio_dev_attr_DAC_update_mode.dev_attr.attr,
&iio_dev_attr_all_DAC_update_modes.dev_attr.attr,
&iio_dev_attr_update_DAC.dev_attr.attr,
- &iio_dev_attr_DAC_internal_Vref.dev_attr.attr,
+ &iio_dev_attr_DAC_internal_vref.dev_attr.attr,
&iio_dev_attr_VDD.dev_attr.attr,
&iio_dev_attr_in_temp.dev_attr.attr,
&iio_dev_attr_ex_temp_AIN1.dev_attr.attr,
--
2.34.1

2023-03-21 06:11:31

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: greybus: remove camel case

On Mon, Mar 20, 2023 at 09:53:42PM +0500, Khadija Kamran wrote:
> Several variables and functions were named Camel Case. This resulted in
> checks pointed by checkpatch.pl
>
> Avoid camel case by changing names.
>
> Signed-off-by: Khadija Kamran <[email protected]>
> ---
> drivers/staging/iio/addac/adt7316.c | 64 ++++++++++++++---------------

This has nothing to do with "greybus" :(

> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 79467f056a05..49702beeac30 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -672,7 +672,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
> adt7316_store_da_high_resolution,
> 0);
>
> -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_show_AIN_internal_vref(struct device *dev,

"Vref" is correct, please keep it as is.

thanks,

greg k-h

2023-03-21 16:41:28

by Khadija Kamran

Subject: Re: [PATCH] staging: greybus: remove camel case

On Tue, Mar 21, 2023 at 07:11:22AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Mar 20, 2023 at 09:53:42PM +0500, Khadija Kamran wrote:
> > Several variables and functions were named Camel Case. This resulted in
> > checks pointed by checkpatch.pl
> >
> > Avoid camel case by changing names.
> >
> > Signed-off-by: Khadija Kamran <[email protected]>
> > ---
> > drivers/staging/iio/addac/adt7316.c | 64 ++++++++++++++---------------
>
> This has nothing to do with "greybus" :(
>

Hi Greg!

I am sorry about making a really silly mistake here.
I will try not to make a mistake like this again.

> > 1 file changed, 32 insertions(+), 32 deletions(-)
> >
> > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> > index 79467f056a05..49702beeac30 100644
> > --- a/drivers/staging/iio/addac/adt7316.c
> > +++ b/drivers/staging/iio/addac/adt7316.c
> > @@ -672,7 +672,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
> > adt7316_store_da_high_resolution,
> > 0);
> >
> > -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> > +static ssize_t adt7316_show_AIN_internal_vref(struct device *dev,
>
> "Vref" is correct, please keep it as is.
>

Okay understood.
Thank you.

Regards,
Khadija


> thanks,
>
> greg k-h