2023-03-28 00:12:23

by Tom Rix

Subject: [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable

clang with W=1 reports
drivers/net/ethernet/8390/axnet_cs.c:653:9: error: variable
'xfer_count' set but not used [-Werror,-Wunused-but-set-variable]
int xfer_count = count;
^
This variable is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/ethernet/8390/axnet_cs.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/8390/axnet_cs.c b/drivers/net/ethernet/8390/axnet_cs.c
index 3aef959fc25b..78f985885547 100644
--- a/drivers/net/ethernet/8390/axnet_cs.c
+++ b/drivers/net/ethernet/8390/axnet_cs.c
@@ -650,7 +650,6 @@ static void block_input(struct net_device *dev, int count,
{
unsigned int nic_base = dev->base_addr;
struct ei_device *ei_local = netdev_priv(dev);
- int xfer_count = count;
char *buf = skb->data;

if ((netif_msg_rx_status(ei_local)) && (count != 4))
@@ -662,9 +661,7 @@ static void block_input(struct net_device *dev, int count,
insw(nic_base + AXNET_DATAPORT,buf,count>>1);
if (count & 0x01) {
buf[count-1] = inb(nic_base + AXNET_DATAPORT);
- xfer_count++;
}
-
}

/*====================================================================*/
--
2.27.0

2023-03-28 18:04:59

by Simon Horman

Subject: Re: [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable

On Mon, Mar 27, 2023 at 07:54:23PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/8390/axnet_cs.c:653:9: error: variable
> 'xfer_count' set but not used [-Werror,-Wunused-but-set-variable]
> int xfer_count = count;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-03-29 07:07:10

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 27 Mar 2023 19:54:23 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/8390/axnet_cs.c:653:9: error: variable
> 'xfer_count' set but not used [-Werror,-Wunused-but-set-variable]
> int xfer_count = count;
> ^
> This variable is not used so remove it.
>
> [...]

Here is the summary with links:
- net: ethernet: 8390: axnet_cs: remove unused xfer_count variable
https://git.kernel.org/netdev/net-next/c/e48cefb9c8d1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html