2023-03-31 22:42:53

by Sudip Mukherjee

[permalink] [raw]
Subject: mainline build failure due to 02852c01f654 ("media: i2c: imx290: Initialize runtime PM before subdev")

Hi All,

The mainline kernel branch had been failing last few weeks for alpha,
csky and s390 allmodconfig with the error:

drivers/media/i2c/imx290.c:1093:12: error: 'imx290_runtime_suspend' defined but not used [-Werror=unused-function]
1093 | static int imx290_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/media/i2c/imx290.c:1085:12: error: 'imx290_runtime_resume' defined but not used [-Werror=unused-function]
1085 | static int imx290_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~

git bisect pointed to 02852c01f654 ("media: i2c: imx290: Initialize runtime PM before subdev")

I will be happy to test any patch or provide any extra log if needed.


--
Regards
Sudip


2023-04-02 10:07:51

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: mainline build failure due to 02852c01f654 ("media: i2c: imx290: Initialize runtime PM before subdev")

On 01.04.23 00:38, Sudip Mukherjee wrote:
>
> The mainline kernel branch had been failing last few weeks for alpha,
> csky and s390 allmodconfig with the error:
>
> drivers/media/i2c/imx290.c:1093:12: error: 'imx290_runtime_suspend' defined but not used [-Werror=unused-function]
> 1093 | static int imx290_runtime_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/media/i2c/imx290.c:1085:12: error: 'imx290_runtime_resume' defined but not used [-Werror=unused-function]
> 1085 | static int imx290_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
> git bisect pointed to 02852c01f654 ("media: i2c: imx290: Initialize runtime PM before subdev")
>
> I will be happy to test any patch or provide any extra log if needed.

I'd assume this was fixed last night by 7b50567bdcad ("media: i2c:
imx290: fix conditional function defintions")

https://git.kernel.org/torvalds/c/7b50567bdcad8925ca1e075feb7171c12015afd1

Ciao, Thorsten