This reverts commit 87e1f7b1a041a37390bf4fa7913683fb4f8d00d8 because it
removed input-enable from the LPASS TLMM, where it is still correct
(both bindings and Linux driver parse it).
Reported-by: Johan Hovold <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/T/#me6c2cc2d87c17c0f30f541e8161a84fdde69f5f5
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 7608a4800732..ef9bd6ab577d 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -2725,6 +2725,7 @@ data-pins {
pins = "gpio7";
function = "dmic1_data";
drive-strength = <8>;
+ input-enable;
};
};
@@ -2742,6 +2743,7 @@ data-pins {
function = "dmic1_data";
drive-strength = <2>;
bias-pull-down;
+ input-enable;
};
};
@@ -2757,6 +2759,7 @@ data-pins {
pins = "gpio9";
function = "dmic2_data";
drive-strength = <8>;
+ input-enable;
};
};
@@ -2774,6 +2777,7 @@ data-pins {
function = "dmic2_data";
drive-strength = <2>;
bias-pull-down;
+ input-enable;
};
};
--
2.34.1
On Tue, Apr 11, 2023 at 07:09:38PM +0200, Krzysztof Kozlowski wrote:
> This reverts commit 87e1f7b1a041a37390bf4fa7913683fb4f8d00d8 because it
Unless using the default revert commit message, I think you should
follow the standard way of referring to commits (e.g. 12 chars SHA +
summary in parenthesis).
> removed input-enable from the LPASS TLMM, where it is still correct
> (both bindings and Linux driver parse it).
>
> Reported-by: Johan Hovold <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/T/#me6c2cc2d87c17c0f30f541e8161a84fdde69f5f5
Are we already accepting Closes tags? I thought that was still under
discussion (even if akpm is currently including this work in his branch
for linux-next). Perhaps better to stick to Link until this has hit
Linus's tree.
Either way, the lore link is unnecessarily long:
Link: https://lore.kernel.org/lkml/[email protected]/
is better and includes the right Message-ID.
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Looks good otherwise:
Reviewed-by: Johan Hovold <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 7608a4800732..ef9bd6ab577d 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -2725,6 +2725,7 @@ data-pins {
> pins = "gpio7";
> function = "dmic1_data";
> drive-strength = <8>;
> + input-enable;
> };
> };
>
> @@ -2742,6 +2743,7 @@ data-pins {
> function = "dmic1_data";
> drive-strength = <2>;
> bias-pull-down;
> + input-enable;
> };
> };
>
> @@ -2757,6 +2759,7 @@ data-pins {
> pins = "gpio9";
> function = "dmic2_data";
> drive-strength = <8>;
> + input-enable;
> };
> };
>
> @@ -2774,6 +2777,7 @@ data-pins {
> function = "dmic2_data";
> drive-strength = <2>;
> bias-pull-down;
> + input-enable;
> };
> };
Johan
On Tue, 11 Apr 2023 19:09:38 +0200, Krzysztof Kozlowski wrote:
> This reverts commit 87e1f7b1a041a37390bf4fa7913683fb4f8d00d8 because it
> removed input-enable from the LPASS TLMM, where it is still correct
> (both bindings and Linux driver parse it).
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc8280xp: Revert "arm64: dts: qcom: sc8280xp: remove superfluous "input-enable""
commit: 2d80b1e649dd74f5226484e244e57990348a9f18
Best regards,
--
Bjorn Andersson <[email protected]>