2023-04-30 04:25:10

by Lizhe

Subject: [PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists

to check if the pinctrl_dev still exists before calling
pinctrl_unregister().

Signed-off-by: Lizhe <[email protected]>
---
drivers/pinctrl/sprd/pinctrl-sprd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index ca9659f4e4b1..6f3369130e8a 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -1115,7 +1115,9 @@ int sprd_pinctrl_remove(struct platform_device *pdev)
{
struct sprd_pinctrl *sprd_pctl = platform_get_drvdata(pdev);

- pinctrl_unregister(sprd_pctl->pctl);
+ if (sprd_pctl->dev)
+ pinctrl_unregister(sprd_pctl->pctl);
+
return 0;
}
EXPORT_SYMBOL_GPL(sprd_pinctrl_remove);
--
2.34.1

2023-04-30 09:48:16

by Andy Shevchenko

Subject: Re: [PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists

Sun, Apr 30, 2023 at 12:22:54PM +0800, Lizhe kirjoitti:
> to check if the pinctrl_dev still exists before calling
> pinctrl_unregister().

Besides commit message has no explanation (and English grammar
incorrectness)...

...

> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -1115,7 +1115,9 @@ int sprd_pinctrl_remove(struct platform_device *pdev)
> {
> struct sprd_pinctrl *sprd_pctl = platform_get_drvdata(pdev);
>
> - pinctrl_unregister(sprd_pctl->pctl);

> + if (sprd_pctl->dev)

...this code is not needed.

> + pinctrl_unregister(sprd_pctl->pctl);
> return 0;
> }

NAK.

--
With Best Regards,
Andy Shevchenko