2023-04-22 14:54:24

by Rong Tao

[permalink] [raw]
Subject: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean

From: Rong Tao <[email protected]>

'make' create 'include' directory, we should remove it when 'make clean'.

Signed-off-by: Rong Tao <[email protected]>
---
v2: this commit, according to William Breathitt Gray's suggession in v1
v1: https://lore.kernel.org/lkml/[email protected]/
---
tools/counter/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/counter/Makefile b/tools/counter/Makefile
index 8843f0fa6119..a0f4cab71fe5 100644
--- a/tools/counter/Makefile
+++ b/tools/counter/Makefile
@@ -40,6 +40,7 @@ $(OUTPUT)counter_example: $(COUNTER_EXAMPLE)
clean:
rm -f $(ALL_PROGRAMS)
rm -rf $(OUTPUT)include/linux/counter.h
+ rmdir -p $(OUTPUT)include/linux
find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete

install: $(ALL_PROGRAMS)
--
2.40.0


2023-04-22 16:08:35

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean

On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <[email protected]>
>
> 'make' create 'include' directory, we should remove it when 'make clean'.
>
> Signed-off-by: Rong Tao <[email protected]>

Hi Rong,

The code changes in this v2 are acceptable for me now, but I would like
the commit description typos fixed. I can fix it myself when I apply
this patch so that you don't need to submit a v3. Would you be okay if I
did that?

William Breathitt Gray


Attachments:
(No filename) (495.00 B)
signature.asc (235.00 B)
Download all attachments

2023-04-23 01:28:23

by Rong Tao

[permalink] [raw]
Subject: Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean

Hi, William,

Of course it's okay, thanks.

Rong Tao

2023-04-23 13:57:15

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean

On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <[email protected]>
>
> 'make' create 'include' directory, we should remove it when 'make clean'.
>
> Signed-off-by: Rong Tao <[email protected]>

Queued (with minor commit description cleanup) for the counter-next
branch of the Counter tree.

Thank you,

William Breathitt Gray


Attachments:
(No filename) (367.00 B)
signature.asc (235.00 B)
Download all attachments