2023-05-11 18:22:21

by Ryan C. Underwood

[permalink] [raw]
Subject: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15


The Pavilion 15 line has B&O top speakers similar to the x360 and
applying the same profile produces good sound. Without this, the
sound would be tinny and underpowered without either applying
model=alc295-hp-x360 or booting another OS first.

Signed-off-by: Ryan Underwood <[email protected]>
---
sound/pci/hda/patch_realtek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e103bb3693c0..7cb232a23a08 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9335,7 +9335,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x802f, "HP Z240", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x103c, 0x8077, "HP", ALC256_FIXUP_HP_HEADSET_MIC),
SND_PCI_QUIRK(0x103c, 0x8158, "HP", ALC256_FIXUP_HP_HEADSET_MIC),
- SND_PCI_QUIRK(0x103c, 0x820d, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
+ SND_PCI_QUIRK(0x103c, 0x820d, "HP Pavilion 15", ALC295_FIXUP_HP_X360),
SND_PCI_QUIRK(0x103c, 0x8256, "HP", ALC221_FIXUP_HP_FRONT_MIC),
SND_PCI_QUIRK(0x103c, 0x827e, "HP x360", ALC295_FIXUP_HP_X360),
SND_PCI_QUIRK(0x103c, 0x827f, "HP x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
--
2.39.2

--
Ryan C. Underwood, <[email protected]>


Attachments:
(No filename) (1.33 kB)
signature.asc (201.00 B)
Download all attachments

2023-05-12 08:31:43

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

On Thu, 11 May 2023 19:32:21 +0200,
Ryan C. Underwood wrote:
>
>
> The Pavilion 15 line has B&O top speakers similar to the x360 and
> applying the same profile produces good sound. Without this, the
> sound would be tinny and underpowered without either applying
> model=alc295-hp-x360 or booting another OS first.
>
> Signed-off-by: Ryan Underwood <[email protected]>

The patch seems mangled by your mailer (spaces instead of tabs).
I applied it manually as it's a trivial change. But at the next time,
please check your mailer setup.

Also, please include all maintainers to Cc :)


thanks,

Takashi

2023-05-12 16:56:40

by Ryan C. Underwood

[permalink] [raw]
Subject: Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

On Fri, May 12, 2023 at 10:28:14AM +0200, Takashi Iwai wrote:
>
> The patch seems mangled by your mailer (spaces instead of tabs).
> I applied it manually as it's a trivial change. But at the next time,
> please check your mailer setup.

Sorry, I pasted to terminal from another system and that must have
mangled it.

> Also, please include all maintainers to Cc :)

Apologies for my ignorance, but what's the correct way to get "all
maintainers" if not scripts/get_maintainer.pl, which you said produced
too many cc's in the previous attempt?

--
Ryan C. Underwood, <[email protected]>


Attachments:
(No filename) (610.00 B)
signature.asc (201.00 B)
Download all attachments