In the end of the test, there will be an error message induced by the
`ip netns del ns1` command in cleanup()
Tests passed: 201
Tests failed: 0
Cannot remove namespace file "/run/netns/ns1": No such file or directory
This can even be reproduced with just `./fib_tests.sh -h` as we're
calling cleanup() on exit.
Redirect the error message to /dev/null to mute it.
V2: Update commit message and fixes tag.
V3: resubmit due to missing netdev ML in V2
Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
Signed-off-by: Po-Hsu Lin <[email protected]>
---
tools/testing/selftests/net/fib_tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
index 7da8ec8..35d89df 100755
--- a/tools/testing/selftests/net/fib_tests.sh
+++ b/tools/testing/selftests/net/fib_tests.sh
@@ -68,7 +68,7 @@ setup()
cleanup()
{
$IP link del dev dummy0 &> /dev/null
- ip netns del ns1
+ ip netns del ns1 &> /dev/null
ip netns del ns2 &> /dev/null
}
--
2.7.4
On Thu, May 18, 2023 at 12:37:59PM +0800, Po-Hsu Lin wrote:
> In the end of the test, there will be an error message induced by the
> `ip netns del ns1` command in cleanup()
>
> Tests passed: 201
> Tests failed: 0
> Cannot remove namespace file "/run/netns/ns1": No such file or directory
>
> This can even be reproduced with just `./fib_tests.sh -h` as we're
> calling cleanup() on exit.
>
> Redirect the error message to /dev/null to mute it.
>
> V2: Update commit message and fixes tag.
> V3: resubmit due to missing netdev ML in V2
>
> Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
> Signed-off-by: Po-Hsu Lin <[email protected]>
Reviewed-by: Ido Schimmel <[email protected]>
On Thu, May 18, 2023 at 12:37:59PM +0800, Po-Hsu Lin wrote:
> In the end of the test, there will be an error message induced by the
> `ip netns del ns1` command in cleanup()
>
> Tests passed: 201
> Tests failed: 0
> Cannot remove namespace file "/run/netns/ns1": No such file or directory
>
> This can even be reproduced with just `./fib_tests.sh -h` as we're
> calling cleanup() on exit.
>
> Redirect the error message to /dev/null to mute it.
>
> V2: Update commit message and fixes tag.
> V3: resubmit due to missing netdev ML in V2
>
> Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
> Signed-off-by: Po-Hsu Lin <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
On Thu, 18 May 2023 12:37:59 +0800 you wrote:
> In the end of the test, there will be an error message induced by the
> `ip netns del ns1` command in cleanup()
>
> Tests passed: 201
> Tests failed: 0
> Cannot remove namespace file "/run/netns/ns1": No such file or directory
>
> [...]
Here is the summary with links:
- [PATCHv3,net] selftests: fib_tests: mute cleanup error message
https://git.kernel.org/netdev/net/c/d226b1df3619
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html