2023-05-23 06:29:49

by Peilin Ye

Subject: [PATCH v3 net 1/6] net/sched: sch_ingress: Only create under TC_H_INGRESS

From: Peilin Ye <[email protected]>

From: Peilin Ye <[email protected]>

ingress Qdiscs are only supposed to be created under TC_H_INGRESS.
Similar to mq_init(), return -EOPNOTSUPP if 'parent' is not
TC_H_INGRESS.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: [email protected]
Closes: https://lore.kernel.org/r/[email protected]/
Reviewed-by: Jamal Hadi Salim <[email protected]>
Acked-by: Jamal Hadi Salim <[email protected]>
Signed-off-by: Peilin Ye <[email protected]>
---
change in v3:
- add in-body From: tag

net/sched/sch_ingress.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c
index 84838128b9c5..3d71f7a3b4ad 100644
--- a/net/sched/sch_ingress.c
+++ b/net/sched/sch_ingress.c
@@ -80,6 +80,9 @@ static int ingress_init(struct Qdisc *sch, struct nlattr *opt,
struct net_device *dev = qdisc_dev(sch);
int err;

+ if (sch->parent != TC_H_INGRESS)
+ return -EOPNOTSUPP;
+
net_inc_ingress_queue();

mini_qdisc_pair_init(&q->miniqp, sch, &dev->miniq_ingress);
--
2.20.1

2023-05-23 07:00:50

by Peilin Ye

Subject: Re: [PATCH v3 net 1/6] net/sched: sch_ingress: Only create under TC_H_INGRESS

On Mon, May 22, 2023 at 11:19:44PM -0700, Peilin Ye wrote:
> From: Peilin Ye <[email protected]>

Wonderful.

> From: Peilin Ye <[email protected]>

Sorry,
Peilin Ye