2023-06-17 09:49:46

by Jisheng Zhang

Subject: [PATCH] mmc: litex_mmc: set PROBE_PREFER_ASYNCHRONOUS

mmc host drivers should have enabled the asynchronous probe option, but
it seems like we didn't set it for litex_mmc when introducing litex mmc
support, so let's set it now.

Tested with linux-on-litex-vexriscv on sipeed tang nano 20K fpga.

Signed-off-by: Jisheng Zhang <[email protected]>
---
drivers/mmc/host/litex_mmc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c
index 39c6707fdfdb..9af6b0902efe 100644
--- a/drivers/mmc/host/litex_mmc.c
+++ b/drivers/mmc/host/litex_mmc.c
@@ -649,6 +649,7 @@ static struct platform_driver litex_mmc_driver = {
.driver = {
.name = "litex-mmc",
.of_match_table = litex_match,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
};
module_platform_driver(litex_mmc_driver);
--
2.40.1

2023-06-17 18:26:42

by Gabriel L. Somlo

Subject: Re: [PATCH] mmc: litex_mmc: set PROBE_PREFER_ASYNCHRONOUS

On Sat, Jun 17, 2023 at 04:53:19PM +0800, Jisheng Zhang wrote:
> mmc host drivers should have enabled the asynchronous probe option, but
> it seems like we didn't set it for litex_mmc when introducing litex mmc
> support, so let's set it now.
>
> Tested with linux-on-litex-vexriscv on sipeed tang nano 20K fpga.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---

Acked-by: Gabriel Somlo <[email protected]>

Thanks!

> drivers/mmc/host/litex_mmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c
> index 39c6707fdfdb..9af6b0902efe 100644
> --- a/drivers/mmc/host/litex_mmc.c
> +++ b/drivers/mmc/host/litex_mmc.c
> @@ -649,6 +649,7 @@ static struct platform_driver litex_mmc_driver = {
> .driver = {
> .name = "litex-mmc",
> .of_match_table = litex_match,
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> };
> module_platform_driver(litex_mmc_driver);
> --
> 2.40.1
>

2023-06-19 12:15:05

by Ulf Hansson

Subject: Re: [PATCH] mmc: litex_mmc: set PROBE_PREFER_ASYNCHRONOUS

On Sat, 17 Jun 2023 at 11:04, Jisheng Zhang <[email protected]> wrote:
>
> mmc host drivers should have enabled the asynchronous probe option, but
> it seems like we didn't set it for litex_mmc when introducing litex mmc
> support, so let's set it now.
>
> Tested with linux-on-litex-vexriscv on sipeed tang nano 20K fpga.
>
> Signed-off-by: Jisheng Zhang <[email protected]>

Applied for fixes, by adding both a fixes and a stable tag, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/litex_mmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c
> index 39c6707fdfdb..9af6b0902efe 100644
> --- a/drivers/mmc/host/litex_mmc.c
> +++ b/drivers/mmc/host/litex_mmc.c
> @@ -649,6 +649,7 @@ static struct platform_driver litex_mmc_driver = {
> .driver = {
> .name = "litex-mmc",
> .of_match_table = litex_match,
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> };
> module_platform_driver(litex_mmc_driver);
> --
> 2.40.1
>