2023-06-09 14:21:06

by Krzysztof Kozlowski

Subject: [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: drop unneeded quotes

Cleanup bindings dropping unneeded quotes. Once all these are fixed,
checking for this can be enabled in yamllint.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
index 4ff6fabfcb30..129e32c4c774 100644
--- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
+++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
@@ -41,7 +41,7 @@ properties:
- description: STR register

aspeed,lpc-io-reg:
- $ref: '/schemas/types.yaml#/definitions/uint32-array'
+ $ref: /schemas/types.yaml#/definitions/uint32-array
minItems: 1
maxItems: 2
description: |
@@ -50,7 +50,7 @@ properties:
status address may be optionally provided.

aspeed,lpc-interrupts:
- $ref: "/schemas/types.yaml#/definitions/uint32-array"
+ $ref: /schemas/types.yaml#/definitions/uint32-array
minItems: 2
maxItems: 2
description: |
@@ -63,12 +63,12 @@ properties:

kcs_chan:
deprecated: true
- $ref: '/schemas/types.yaml#/definitions/uint32'
+ $ref: /schemas/types.yaml#/definitions/uint32
description: The LPC channel number in the controller

kcs_addr:
deprecated: true
- $ref: '/schemas/types.yaml#/definitions/uint32'
+ $ref: /schemas/types.yaml#/definitions/uint32
description: The host CPU IO map address

required:
--
2.34.1

2023-06-09 23:48:17

by Andrew Jeffery

Subject: Re: [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: drop unneeded quotes

On Fri, 9 Jun 2023, at 23:37, Krzysztof Kozlowski wrote:
> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> checking for this can be enabled in yamllint.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Andrew Jeffery <[email protected]>

> ---
> .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> index 4ff6fabfcb30..129e32c4c774 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> @@ -41,7 +41,7 @@ properties:
> - description: STR register
>
> aspeed,lpc-io-reg:
> - $ref: '/schemas/types.yaml#/definitions/uint32-array'
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 1
> maxItems: 2
> description: |
> @@ -50,7 +50,7 @@ properties:
> status address may be optionally provided.
>
> aspeed,lpc-interrupts:
> - $ref: "/schemas/types.yaml#/definitions/uint32-array"
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 2
> maxItems: 2
> description: |
> @@ -63,12 +63,12 @@ properties:
>
> kcs_chan:
> deprecated: true
> - $ref: '/schemas/types.yaml#/definitions/uint32'
> + $ref: /schemas/types.yaml#/definitions/uint32
> description: The LPC channel number in the controller
>
> kcs_addr:
> deprecated: true
> - $ref: '/schemas/types.yaml#/definitions/uint32'
> + $ref: /schemas/types.yaml#/definitions/uint32
> description: The host CPU IO map address
>
> required:
> --
> 2.34.1

2023-06-10 13:13:19

by Corey Minyard

Subject: Re: [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: drop unneeded quotes

On Sat, Jun 10, 2023 at 08:49:27AM +0930, Andrew Jeffery wrote:
>
>
> On Fri, 9 Jun 2023, at 23:37, Krzysztof Kozlowski wrote:
> > Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> > checking for this can be enabled in yamllint.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Acked-by: Andrew Jeffery <[email protected]>

This is in my next tree. Thank you.

-corey

>
> > ---
> > .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> > b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> > index 4ff6fabfcb30..129e32c4c774 100644
> > --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> > +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> > @@ -41,7 +41,7 @@ properties:
> > - description: STR register
> >
> > aspeed,lpc-io-reg:
> > - $ref: '/schemas/types.yaml#/definitions/uint32-array'
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > minItems: 1
> > maxItems: 2
> > description: |
> > @@ -50,7 +50,7 @@ properties:
> > status address may be optionally provided.
> >
> > aspeed,lpc-interrupts:
> > - $ref: "/schemas/types.yaml#/definitions/uint32-array"
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > minItems: 2
> > maxItems: 2
> > description: |
> > @@ -63,12 +63,12 @@ properties:
> >
> > kcs_chan:
> > deprecated: true
> > - $ref: '/schemas/types.yaml#/definitions/uint32'
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > description: The LPC channel number in the controller
> >
> > kcs_addr:
> > deprecated: true
> > - $ref: '/schemas/types.yaml#/definitions/uint32'
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > description: The host CPU IO map address
> >
> > required:
> > --
> > 2.34.1