2023-06-10 06:17:00

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] Documentation: virt: correct location of haltpoll module params

Module parameters are located in sysfs, not debugfs, so correct the
statement.

Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Marcelo Tosatti <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: [email protected]
---
Documentation/virt/guest-halt-polling.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
--- a/Documentation/virt/guest-halt-polling.rst
+++ b/Documentation/virt/guest-halt-polling.rst
@@ -72,7 +72,7 @@ high once achieves global guest_halt_pol

Default: Y

-The module parameters can be set from the debugfs files in::
+The module parameters can be set from the sysfs files in::

/sys/module/haltpoll/parameters/



2023-06-12 01:46:25

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] Documentation: virt: correct location of haltpoll module params

On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
> --- a/Documentation/virt/guest-halt-polling.rst
> +++ b/Documentation/virt/guest-halt-polling.rst
> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>
> Default: Y
>
> -The module parameters can be set from the debugfs files in::
> +The module parameters can be set from the sysfs files in::
>
> /sys/module/haltpoll/parameters/
>

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <[email protected]>

--
An old man doll... just what I always wanted! - Clara

Attachments:
(No filename) (659.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-06-12 19:05:05

by Marcelo Tosatti

[permalink] [raw]
Subject: Re: [PATCH] Documentation: virt: correct location of haltpoll module params

On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
> Module parameters are located in sysfs, not debugfs, so correct the
> statement.
>
> Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Marcelo Tosatti <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: [email protected]
> ---
> Documentation/virt/guest-halt-polling.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
> --- a/Documentation/virt/guest-halt-polling.rst
> +++ b/Documentation/virt/guest-halt-polling.rst
> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>
> Default: Y
>
> -The module parameters can be set from the debugfs files in::
> +The module parameters can be set from the sysfs files in::
>
> /sys/module/haltpoll/parameters/
>
>
>

Signed-off-by: Marcelo Tosatti <[email protected]>


2023-06-16 14:35:35

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] Documentation: virt: correct location of haltpoll module params

Marcelo Tosatti <[email protected]> writes:

> On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
>> Module parameters are located in sysfs, not debugfs, so correct the
>> statement.
>>
>> Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Marcelo Tosatti <[email protected]>
>> Cc: "Rafael J. Wysocki" <[email protected]>
>> Cc: Jonathan Corbet <[email protected]>
>> Cc: [email protected]
>> ---
>> Documentation/virt/guest-halt-polling.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
>> --- a/Documentation/virt/guest-halt-polling.rst
>> +++ b/Documentation/virt/guest-halt-polling.rst
>> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>>
>> Default: Y
>>
>> -The module parameters can be set from the debugfs files in::
>> +The module parameters can be set from the sysfs files in::
>>
>> /sys/module/haltpoll/parameters/
>>
>>
>>
>
> Signed-off-by: Marcelo Tosatti <[email protected]>

I'm not sure why you're offering a signoff for Randy's patch...?

In any case, I've taken this as an ack and applied it.

Thanks,

jon