2023-06-28 00:58:05

by Tobias Heider

[permalink] [raw]
Subject: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.

Fixes a bug where on the M1 mac mini initramfs-tools fails to
include the necessary firmware into the initrd.

Signed-off-by: Tobias Heider <[email protected]>
---
drivers/net/ethernet/broadcom/tg3.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 58747292521d..a52cf9aae498 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -224,6 +224,7 @@ MODULE_AUTHOR("David S. Miller ([email protected]) and Jeff Garzik (jgarzik@pobox
MODULE_DESCRIPTION("Broadcom Tigon3 ethernet driver");
MODULE_LICENSE("GPL");
MODULE_FIRMWARE(FIRMWARE_TG3);
+MODULE_FIRMWARE(FIRMWARE_TG357766);
MODULE_FIRMWARE(FIRMWARE_TG3TSO);
MODULE_FIRMWARE(FIRMWARE_TG3TSO5);

--
2.39.2



2023-06-28 01:41:59

by Michael Chan

[permalink] [raw]
Subject: Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.

On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <[email protected]> wrote:
>
> Fixes a bug where on the M1 mac mini initramfs-tools fails to
> include the necessary firmware into the initrd.
>
> Signed-off-by: Tobias Heider <[email protected]>

Thanks.
Reviewed-by: Michael Chan <[email protected]>

Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2023-06-29 13:07:58

by Paolo Abeni

[permalink] [raw]
Subject: Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.

On Tue, 2023-06-27 at 18:31 -0700, Michael Chan wrote:
> On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <[email protected]> wrote:
> >
> > Fixes a bug where on the M1 mac mini initramfs-tools fails to
> > include the necessary firmware into the initrd.
> >
> > Signed-off-by: Tobias Heider <[email protected]>
>
> Thanks.
> Reviewed-by: Michael Chan <[email protected]>

This is a borderline situation, but ... 

Is there a suitable 'Fixes:' tag we can add here?

Thanks!

Paolo


2023-06-29 14:12:03

by Tobias Heider

[permalink] [raw]
Subject: Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.

On Thu, Jun 29, 2023 at 03:05:23PM +0200, Paolo Abeni wrote:
> On Tue, 2023-06-27 at 18:31 -0700, Michael Chan wrote:
> > On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <[email protected]> wrote:
> > >
> > > Fixes a bug where on the M1 mac mini initramfs-tools fails to
> > > include the necessary firmware into the initrd.
> > >
> > > Signed-off-by: Tobias Heider <[email protected]>
> >
> > Thanks.
> > Reviewed-by: Michael Chan <[email protected]>
>
> This is a borderline situation, but ... 
>
> Is there a suitable 'Fixes:' tag we can add here?
>
> Thanks!
>
> Paolo
>

Would "Fixes: c4dab50697ff ("video: remove unnecessary platform_set_drvdata()")"
work?

2023-06-29 16:25:03

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.

On Thu, 29 Jun 2023 15:37:05 +0200 Tobias Heider wrote:
> Would "Fixes: c4dab50697ff ("video: remove unnecessary platform_set_drvdata()")"
> work?

Modulo the text in the brackets but yes ;) I'll add when applying.

2023-06-29 17:31:20

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 28 Jun 2023 02:13:32 +0200 you wrote:
> Fixes a bug where on the M1 mac mini initramfs-tools fails to
> include the necessary firmware into the initrd.
>
> Signed-off-by: Tobias Heider <[email protected]>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 1 +
> 1 file changed, 1 insertion(+)

Here is the summary with links:
- Add MODULE_FIRMWARE() for FIRMWARE_TG357766.
https://git.kernel.org/netdev/net/c/046f753da614

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html