2023-06-21 07:18:55

by sunliming

Subject: [PATCH v3 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test

The user_event has not be enabled in write_fault test in ftrace
self-test, Just enable it.

Signed-off-by: sunliming <[email protected]>
---
tools/testing/selftests/user_events/ftrace_test.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
index abfb49558a26..d33bd31425db 100644
--- a/tools/testing/selftests/user_events/ftrace_test.c
+++ b/tools/testing/selftests/user_events/ftrace_test.c
@@ -373,6 +373,10 @@ TEST_F(user, write_fault) {
ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, &reg));
ASSERT_EQ(0, reg.write_index);

+ /* Enable event */
+ self->enable_fd = open(enable_file, O_RDWR);
+ ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
+
/* Write should work normally */
ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2));

--
2.25.1

2023-06-22 20:31:22

by Beau Belgrave

Subject: Re: [PATCH v3 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test

On Wed, Jun 21, 2023 at 02:34:38PM +0800, sunliming wrote:
> The user_event has not be enabled in write_fault test in ftrace
> self-test, Just enable it.
>
> Signed-off-by: sunliming <[email protected]>

Good catch.

Acked-by: Beau Belgrave <[email protected]>

Thanks!

> ---
> tools/testing/selftests/user_events/ftrace_test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
> index abfb49558a26..d33bd31425db 100644
> --- a/tools/testing/selftests/user_events/ftrace_test.c
> +++ b/tools/testing/selftests/user_events/ftrace_test.c
> @@ -373,6 +373,10 @@ TEST_F(user, write_fault) {
> ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, &reg));
> ASSERT_EQ(0, reg.write_index);
>
> + /* Enable event */
> + self->enable_fd = open(enable_file, O_RDWR);
> + ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
> +
> /* Write should work normally */
> ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2));
>
> --
> 2.25.1