2023-06-22 16:47:20

by Yunlei He

Subject: [f2fs-dev][PATCH 1/2 v2] f2fs: update mtime and ctime in move file range method

Mtime and ctime stay old value without update after move
file range ioctl. This patch add time update.

Signed-off-by: Yunlei He <[email protected]>
---
v2:
-update both src and dst inode
fs/f2fs/file.c | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index cb42d8464ad9..e59fc8faa035 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2886,6 +2886,19 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
f2fs_up_write(&F2FS_I(dst)->i_gc_rwsem[WRITE]);
out_src:
f2fs_up_write(&F2FS_I(src)->i_gc_rwsem[WRITE]);
+
+ if (!ret) {
+ src->i_mtime = src->i_ctime = current_time(src);
+ f2fs_mark_inode_dirty_sync(src, false);
+
+ if (src != dst) {
+ dst->i_mtime = dst->i_ctime = current_time(dst);
+ f2fs_mark_inode_dirty_sync(dst, false);
+ }
+
+ f2fs_update_time(sbi, REQ_TIME);
+ }
+
out_unlock:
if (src != dst)
inode_unlock(dst);
--
2.40.1

2023-06-23 02:26:18

by Chao Yu

Subject: Re: [f2fs-dev][PATCH 1/2 v2] f2fs: update mtime and ctime in move file range method

On 2023/6/23 0:16, Yunlei He wrote:
> Mtime and ctime stay old value without update after move
> file range ioctl. This patch add time update.
>
> Signed-off-by: Yunlei He <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-06-23 19:33:07

by Jaegeuk Kim

Subject: Re: [f2fs-dev][PATCH 1/2 v2] f2fs: update mtime and ctime in move file range method

On 06/23, Yunlei He wrote:
> Mtime and ctime stay old value without update after move
> file range ioctl. This patch add time update.
>
> Signed-off-by: Yunlei He <[email protected]>
> ---
> v2:
> -update both src and dst inode
> fs/f2fs/file.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index cb42d8464ad9..e59fc8faa035 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2886,6 +2886,19 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
> f2fs_up_write(&F2FS_I(dst)->i_gc_rwsem[WRITE]);
> out_src:
> f2fs_up_write(&F2FS_I(src)->i_gc_rwsem[WRITE]);
> +
> + if (!ret) {

Applied with minor change like:

if (ret)
goto out_unlock;
...

> + src->i_mtime = src->i_ctime = current_time(src);
> + f2fs_mark_inode_dirty_sync(src, false);
> +
> + if (src != dst) {
> + dst->i_mtime = dst->i_ctime = current_time(dst);
> + f2fs_mark_inode_dirty_sync(dst, false);
> + }
> +
> + f2fs_update_time(sbi, REQ_TIME);
> + }
> +
> out_unlock:
> if (src != dst)
> inode_unlock(dst);
> --
> 2.40.1