2023-06-21 08:07:48

by Rong Tao

Subject: [PATCH] docs: trace: Convert decode_msr.py print syntax to python3

From: Rong Tao <[email protected]>

Convert the decode_msr.py file to python3 to solve the following running
errors:

File "Documentation/trace/postprocess/decode_msr.py", line 35
print j,
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean
print(j, end=" ")?

Signed-off-by: Rong Tao <[email protected]>
---
Documentation/trace/postprocess/decode_msr.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/trace/postprocess/decode_msr.py b/Documentation/trace/postprocess/decode_msr.py
index aa9cc7abd5c2..2d45d6c14987 100644
--- a/Documentation/trace/postprocess/decode_msr.py
+++ b/Documentation/trace/postprocess/decode_msr.py
@@ -32,6 +32,6 @@ for j in sys.stdin:
break
if r:
j = j.replace(" " + m.group(2), " " + r + "(" + m.group(2) + ")")
- print j,
+ print(j + ",")


--
2.39.3

2023-06-21 15:33:52

by Jonathan Corbet

Subject: Re: [PATCH] docs: trace: Convert decode_msr.py print syntax to python3

[Adding Andi]

Rong Tao <[email protected]> writes:

> From: Rong Tao <[email protected]>
>
> Convert the decode_msr.py file to python3 to solve the following running
> errors:
>
> File "Documentation/trace/postprocess/decode_msr.py", line 35
> print j,
> ^
> SyntaxError: Missing parentheses in call to 'print'. Did you mean
> print(j, end=" ")?
>
> Signed-off-by: Rong Tao <[email protected]>
> ---
> Documentation/trace/postprocess/decode_msr.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/postprocess/decode_msr.py b/Documentation/trace/postprocess/decode_msr.py
> index aa9cc7abd5c2..2d45d6c14987 100644
> --- a/Documentation/trace/postprocess/decode_msr.py
> +++ b/Documentation/trace/postprocess/decode_msr.py
> @@ -32,6 +32,6 @@ for j in sys.stdin:
> break
> if r:
> j = j.replace(" " + m.group(2), " " + r + "(" + m.group(2) + ")")
> - print j,
> + print(j + ",")

So I certainly have no problem applying this. But it occurs to me that
this file hasn't been touched since it was added in 2015, and nobody has
complained that it doesn't work with modern Python. That leads me to
wonder if it's being used at all.

Assuming that there is value in keeping it, I wonder if a move to
samples/ might make sense?

Thanks,

jon

2023-06-25 01:15:02

by Rong Tao

Subject: Re: [PATCH] docs: trace: Convert decode_msr.py print syntax to python3

Thanks for your reply, jon. How about i submit v2 to remove decode_msr.py
totally?

Do the two remaining perl scripts need to be removed?

- Documentation/trace/postprocess/trace-pagealloc-postprocess.pl
- Documentation/trace/postprocess/trace-vmscan-postprocess.pl

Thanks,

Rong Tao.

2023-06-25 15:21:29

by Andi Kleen

Subject: Re: [PATCH] docs: trace: Convert decode_msr.py print syntax to python3

On Sun, Jun 25, 2023 at 09:03:57AM +0800, Rong Tao wrote:
> Thanks for your reply, jon. How about i submit v2 to remove decode_msr.py
> totally?

Well only if you can explain how the MSR tracer should be used without
it?

Not sure I understand the whole discussion here.


-Andi