2023-06-27 06:24:19

by Tree Davies

Subject: [PATCH v3] staging: rtl8192e: Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps

Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps in order to
fix checkpatch warning: Avoid CamelCase

Signed-off-by: Tree Davies <[email protected]>
---
v3: Fix email parch as v2 info was placed above the ---
v2: Rename is_ht_half_nmode_a_ps -> is_ht_half_nmode_aps
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index f9fa3f2bb728..d09342dde61d 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -139,7 +139,7 @@ u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate)
return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
}

-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
{
bool retValue = false;
struct rtllib_network *net = &ieee->current_network;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index e3ce4431d460..293eb9315d99 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -2003,7 +2003,7 @@ extern u8 MCS_FILTER_ALL[];
extern u16 MCS_DATA_RATE[2][2][77];
u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate);
int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 425d4acbcdf0..05740e90d1c6 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -2224,7 +2224,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
ieee->softmac_stats.rx_auth_rs_ok++;
if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) {
if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) {
- if (IsHTHalfNmodeAPs(ieee)) {
+ if (is_ht_half_nmode_aps(ieee)) {
bSupportNmode = true;
bHalfSupportNmode = true;
} else {
--
2.39.2

2023-06-28 20:54:13

by Philipp Hortmann

Subject: Re: [PATCH v3] staging: rtl8192e: Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps

On 6/27/23 08:12, Tree Davies wrote:
> Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps in order to
> fix checkpatch warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <[email protected]>
> ---
> v3: Fix email parch as v2 info was placed above the ---
> v2: Rename is_ht_half_nmode_a_ps -> is_ht_half_nmode_aps
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>

Tested-by: Philipp Hortmann <[email protected]>

2023-07-27 08:14:57

by Greg Kroah-Hartman

Subject: Re: [PATCH v3] staging: rtl8192e: Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps

On Mon, Jun 26, 2023 at 11:12:46PM -0700, Tree Davies wrote:
> Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps in order to
> fix checkpatch warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <[email protected]>
> ---
> v3: Fix email parch as v2 info was placed above the ---
> v2: Rename is_ht_half_nmode_a_ps -> is_ht_half_nmode_aps
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index f9fa3f2bb728..d09342dde61d 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -139,7 +139,7 @@ u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate)
> return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
> }
>
> -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
> +bool is_ht_half_nmode_aps(struct rtllib_device *ieee)

As this is a global symbol, can you please prefix it with the driver
name so that the global symbol table looks semi-sane?

Perhaps rtllib_is_ht_half_nmode_aps()?

thanks,

greg k-h