Since commit 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba
driver"), there is no more request_mem_region() call in this driver.
So remove the release_mem_region() call from the remove function which is
likely a left over.
Fixes: 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba driver")
Cc: <[email protected]> # v3.6+
Acked-by: Linus Walleij <[email protected]>
Reviewed-by: Andi Shyti <[email protected]>
Signed-off-by: Christophe JAILLET <[email protected]>
---
v3: - update commit description
- add R-b and A-b
- fix Fixes tag [Dan Carpenter]
- add cc stable [Andi Shyti]
v2: - synch with latest -next
- https://lore.kernel.org/all/62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr/
v1: - https://lore.kernel.org/all/4f4c2c5c20b61c4bb28cb3e9ab4640534dd2adec.1629530169.git.christophe.jaillet@wanadoo.fr/
---
drivers/i2c/busses/i2c-nomadik.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 1e5fd23ef45c..212f412f1c74 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -1038,7 +1038,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
static void nmk_i2c_remove(struct amba_device *adev)
{
- struct resource *res = &adev->res;
struct nmk_i2c_dev *dev = amba_get_drvdata(adev);
i2c_del_adapter(&dev->adap);
@@ -1047,7 +1046,6 @@ static void nmk_i2c_remove(struct amba_device *adev)
clear_all_interrupts(dev);
/* disable the controller */
i2c_clr_bit(dev->virtbase + I2C_CR, I2C_CR_PE);
- release_mem_region(res->start, resource_size(res));
}
static struct i2c_vendor_data vendor_stn8815 = {
--
2.34.1
On Tue, Jul 04, 2023 at 09:50:28PM +0200, Christophe JAILLET wrote:
> Since commit 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba
> driver"), there is no more request_mem_region() call in this driver.
>
> So remove the release_mem_region() call from the remove function which is
> likely a left over.
>
> Fixes: 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba driver")
> Cc: <[email protected]> # v3.6+
> Acked-by: Linus Walleij <[email protected]>
> Reviewed-by: Andi Shyti <[email protected]>
> Signed-off-by: Christophe JAILLET <[email protected]>
Applied to for-current, thanks!