2023-07-05 10:01:01

by 李扬韬

Subject: [PATCH 8/8] fpga: zynq-fpga: Convert to devm_platform_ioremap_resource()

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/fpga/zynq-fpga.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index f8214cae9b6e..96611d424a10 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct zynq_fpga_priv *priv;
struct fpga_manager *mgr;
- struct resource *res;
int err;

priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev)
return -ENOMEM;
spin_lock_init(&priv->dma_lock);

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->io_base = devm_ioremap_resource(dev, res);
+ priv->io_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->io_base))
return PTR_ERR(priv->io_base);

--
2.39.0

2023-07-07 05:09:40

by Michal Simek

Subject: Re: [PATCH 8/8] fpga: zynq-fpga: Convert to devm_platform_ioremap_resource()

On 7/5/23 11:46, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/fpga/zynq-fpga.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index f8214cae9b6e..96611d424a10 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct zynq_fpga_priv *priv;
> struct fpga_manager *mgr;
> - struct resource *res;
> int err;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> return -ENOMEM;
> spin_lock_init(&priv->dma_lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->io_base = devm_ioremap_resource(dev, res);
> + priv->io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->io_base))
> return PTR_ERR(priv->io_base);
>

Acked-by: Michal Simek <[email protected]>

M

2023-07-10 09:04:15

by Xu Yilun

Subject: Re: [PATCH 8/8] fpga: zynq-fpga: Convert to devm_platform_ioremap_resource()

On 2023-07-07 at 06:55:49 +0200, Michal Simek wrote:
>
>
> On 7/5/23 11:46, Yangtao Li wrote:
> > Use devm_platform_ioremap_resource() to simplify code.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
> > ---
> > drivers/fpga/zynq-fpga.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> > index f8214cae9b6e..96611d424a10 100644
> > --- a/drivers/fpga/zynq-fpga.c
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> > struct device *dev = &pdev->dev;
> > struct zynq_fpga_priv *priv;
> > struct fpga_manager *mgr;
> > - struct resource *res;
> > int err;
> > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> > return -ENOMEM;
> > spin_lock_init(&priv->dma_lock);
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - priv->io_base = devm_ioremap_resource(dev, res);
> > + priv->io_base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(priv->io_base))
> > return PTR_ERR(priv->io_base);
>
> Acked-by: Michal Simek <[email protected]>

Acked-by: Xu Yilun <[email protected]>

Applied.

>
> M